From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rik van Riel <riel@redhat.com>
Subject: Re: [PATCH 21/43] CacheFiles: Be consistent about the use of mapping
	vs	file->f_mapping in Ext3 [ver #46]
Date: Thu, 02 Apr 2009 14:52:43 -0400
Message-ID: <49D5097B.7020802@redhat.com>
References: <20090401230321.28177.12010.stgit@warthog.procyon.org.uk>
	<20090401230510.28177.98253.stgit@warthog.procyon.org.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: linux-fsdevel@vger.kernel.org, nfsv4@linux-nfs.org, viro@ZenIV.linux.org.uk,
	linux-kernel@vger.kernel.org
To: David Howells <dhowells@redhat.com>
Return-path: <nfsv4-bounces@linux-nfs.org>
In-Reply-To: <20090401230510.28177.98253.stgit@warthog.procyon.org.uk>
List-Unsubscribe: <http://linux-nfs.org/cgi-bin/mailman/listinfo/nfsv4>,
	<mailto:nfsv4-request@linux-nfs.org?subject=unsubscribe>
List-Archive: <http://linux-nfs.org/pipermail/nfsv4>
List-Post: <mailto:nfsv4@linux-nfs.org>
List-Help: <mailto:nfsv4-request@linux-nfs.org?subject=help>
List-Subscribe: <http://linux-nfs.org/cgi-bin/mailman/listinfo/nfsv4>,
	<mailto:nfsv4-request@linux-nfs.org?subject=subscribe>
Sender: nfsv4-bounces@linux-nfs.org
Errors-To: nfsv4-bounces@linux-nfs.org
List-Id: linux-fsdevel.vger.kernel.org

David Howells wrote:
> Change all the usages of file->f_mapping in ext3_*write_end() functions to use
> the mapping argument directly.  This has two consequences:
>
>  (*) Consistency.  Without this patch sometimes one is used and sometimes the
>      other is.
>
>  (*) A NULL file pointer can be passed.  This feature is then made use of by
>      the generic hook in the next patch, which is used by CacheFiles to write
>      pages to a file without setting up a file struct.
>
> Signed-off-by: David Howells <dhowells@redhat.com>
> Acked-by: Steve Dickson <steved@redhat.com>
> Acked-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Acked-by: Rik van Riel <riel@redhat.com>