From: jim owens <jowens@hp.com>
To: Andreas Dilger <adilger@sun.com>
Cc: Oleg Drokin <green@linuxhacker.ru>, linux-fsdevel@vger.kernel.org
Subject: Re: Attempt at "stat light" implementation
Date: Tue, 07 Apr 2009 11:22:25 -0400 [thread overview]
Message-ID: <49DB6FB1.1060504@hp.com> (raw)
In-Reply-To: <20090407102340.GT3204@webber.adilger.int>
Sorry our travel budget didn't allow me to be there
for the spirited discussion ;)
I don't have anything against a selective stat function
except that it adds extra conditional code that my
experience says won't be much benefit.
We have a selective getattr in Tru64 for clusters with
the same idea that it would save a lot of expensive
operations in the cluster.
It did *not*.
The problems are:
- applications are not smart (except maybe on luster).
- applications find it easier and usually faster to get
all the stat info and sort it themselves, particularly
when they are tested exclusively on local systems.
- who is going to fix (and keep fixed) those gui file managers
(and stop users from "ls -l" or viewing properties)?
- even internal kernel getattrs would often make a "light"
call, then the next operation needed the "heavy" attrs,
so we sent 2 RPCs instead of 1 and had to do a lot more
complicated local attr cache management of what fields
were valid in cache and what were not.
And I spent a lot of time fixing attr cache and cluster
locking problems in the cluster FS and NFS code.
So by trying to save expensive operations, it made it worse.
One practical suggestion: for fields that were not requested,
we sent back the "illegal/ignore" (usually -1) value that
could be used in a subsequent setattr.
jim
next prev parent reply other threads:[~2009-04-07 15:23 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-07 6:23 Attempt at "stat light" implementation Oleg Drokin
2009-04-07 10:23 ` Andreas Dilger
2009-04-07 14:54 ` Oleg Drokin
2009-04-07 17:52 ` Christoph Hellwig
2009-04-07 15:22 ` jim owens [this message]
2009-04-07 15:38 ` Oleg Drokin
2009-04-07 16:20 ` jim owens
2009-04-07 17:32 ` Jamie Lokier
2009-04-07 17:38 ` Jeff Garzik
2009-04-07 17:56 ` Jamie Lokier
2009-04-07 18:21 ` Andreas Dilger
2009-04-07 19:30 ` Ulrich Drepper
2009-04-12 20:55 ` Jamie Lokier
2009-04-07 17:41 ` Oleg Drokin
2009-04-07 17:54 ` Jamie Lokier
2009-04-07 18:00 ` Oleg Drokin
2009-04-07 18:18 ` Andreas Dilger
2009-04-07 18:31 ` Nicholas Miell
2009-04-07 17:49 ` Christoph Hellwig
2009-04-07 17:56 ` Oleg Drokin
2009-04-07 18:28 ` Andreas Dilger
2009-04-07 18:50 ` Jamie Lokier
2009-04-07 19:48 ` Jeff Garzik
2009-04-07 19:47 ` Jeff Garzik
2009-04-07 20:18 ` Evgeniy Polyakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49DB6FB1.1060504@hp.com \
--to=jowens@hp.com \
--cc=adilger@sun.com \
--cc=green@linuxhacker.ru \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).