Re: [PATCH] Oversight in generic_file_aio_write_nolock

[Jeff Garzik <jeff@garzik.org>]

Oleg Drokin wrote:
> Hello!
> 
>    There seems to be an oversight in generic_file_aio_write_nolock where
>    when we open inode with O_SYNC and O_APPEND, then after we are done the
>    writing, we flush wrong byterange from the file, from original offset for
>    number of bytes written, instead from the actual oppended offset.
>    This can lead to an unexpected data loss should the crash happen soon after
>    such a write was performed.
> 
>    Here is a simple fix, though perhaps we can just throw away the pos argument
>    from the ->aio_write prototype eventually.

Could I ask that you CC patches like this to linux-kernel also?

	Jeff