From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Simek Subject: Re: [LTP] statvfs -> f_bavail Date: Mon, 20 Apr 2009 08:16:50 +0200 Message-ID: <49EC1352.6010900@petalogix.com> References: <49E759FB.70103@petalogix.com> <49E847FB.1030801@petalogix.com> <20090417173107.GA3590@refried.org> Reply-To: michal.simek@petalogix.com Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: subrata@linux.vnet.ibm.com, ltp-list@lists.sourceforge.net, John Williams , Linux Kernel list , linux-fsdevel@vger.kernel.org To: Nate Straz Return-path: Received: from fg-out-1718.google.com ([72.14.220.157]:24363 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752721AbZDTGQz (ORCPT ); Mon, 20 Apr 2009 02:16:55 -0400 In-Reply-To: <20090417173107.GA3590@refried.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Nate Straz wrote: > On Apr 17 11:12, Michal Simek wrote: > >>> don't you know what is the description of f_bavail in struct statvfs? >>> On my system I am getting zero for this entry that's why fsync02 failed. >>> >>> >> I track down where the problem comes from. >> There is problem for all fs which use simple_statfs function from >> fs/libfs.c. >> In open.c in vfs_statfs function is whole structure set to zero and then >> in simple_statfs not set this value. >> I think we should fix it in ltp code. >> Here is my proposed change. If is ok - I will generate proper patch. >> > > If the problem is in the kernel, then it should be fixed in the kernel. > That's the whole point of LTP, pointing out problems in the kernel which > need to be fixed. Patching LTP to work around f_bavail not being set > correctly is not the right thing to do. > :-) And what about if is the kernel code ok? :-) Then IMHO is the right time to fix LTP. The main question is if is or not. Hi guys from linux-fsdevel: Can you told us what is the right solution for my problem above? Thanks, Michal > Nate > -- Michal Simek, Ing. (M.Eng) PetaLogix - Linux Solutions for a Reconfigurable World w: www.petalogix.com p: +61-7-30090663,+42-0-721842854 f: +61-7-30090663