From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roel Kluin Subject: [PATCH] ROMFS: romfs_dev_read() error ignored Date: Sun, 26 Apr 2009 14:51:17 +0200 Message-ID: <49F458C5.9060707@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org To: Al Viro Return-path: Received: from mail-ew0-f176.google.com ([209.85.219.176]:58305 "EHLO mail-ew0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752450AbZDZMvT (ORCPT ); Sun, 26 Apr 2009 08:51:19 -0400 Received: by ewy24 with SMTP id 24so1712695ewy.37 for ; Sun, 26 Apr 2009 05:51:17 -0700 (PDT) Sender: linux-fsdevel-owner@vger.kernel.org List-ID: romfs_dev_read() may return -EIO, but ret is unsigned, so the errorpath isn't taken. Signed-off-by: Roel Kluin --- diff --git a/fs/romfs/super.c b/fs/romfs/super.c index c53b5ef..4ab3c03 100644 --- a/fs/romfs/super.c +++ b/fs/romfs/super.c @@ -298,7 +298,8 @@ static struct inode *romfs_iget(struct super_block *sb, unsigned long pos) struct romfs_inode ri; struct inode *i; unsigned long nlen; - unsigned nextfh, ret; + unsigned nextfh; + int ret; umode_t mode; /* we might have to traverse a chain of "hard link" file entries to get