linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Matthew Wilcox <matthew@wil.cx>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: [PATCH] lockd: fix FILE_LOCKING=n build error
Date: Tue, 28 Apr 2009 08:22:50 -0700	[thread overview]
Message-ID: <49F71F4A.3080908@oracle.com> (raw)
In-Reply-To: <20090428165343.2e357d7a.sfr@canb.auug.org.au>

From: Randy Dunlap <randy.dunlap@oracle.com>

lockd/svclock.c is missing a header file <linux/fs.h>.

<linux/fs.h> is missing a definition of locks_release_private()
for the config case of FILE_LOCKING=n, causing a build error:

fs/lockd/svclock.c:330: error: implicit declaration of function 'locks_release_private'

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
 fs/lockd/svclock.c |    1 +
 include/linux/fs.h |    4 ++++
 2 files changed, 5 insertions(+)

--- linux-next-20090428.orig/fs/lockd/svclock.c
+++ linux-next-20090428/fs/lockd/svclock.c
@@ -22,6 +22,7 @@
 
 #include <linux/types.h>
 #include <linux/errno.h>
+#include <linux/fs.h>
 #include <linux/kernel.h>
 #include <linux/sched.h>
 #include <linux/smp_lock.h>
--- linux-next-20090428.orig/include/linux/fs.h
+++ linux-next-20090428/include/linux/fs.h
@@ -1183,6 +1183,10 @@ static inline void locks_remove_flock(st
 	return;
 }
 
+static inline void locks_release_private(struct file_lock *fl)
+{
+}
+
 static inline void posix_test_lock(struct file *filp, struct file_lock *fl)
 {
 	return;

-- 
~Randy

       reply	other threads:[~2009-04-28 15:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20090428165343.2e357d7a.sfr@canb.auug.org.au>
2009-04-28 15:22 ` Randy Dunlap [this message]
2009-04-28 15:38   ` [PATCH] lockd: fix FILE_LOCKING=n build error Felix Blyakher
2009-04-28 17:21   ` J. Bruce Fields
2009-04-28 17:51     ` Randy Dunlap
2009-04-28 18:15       ` Trond Myklebust
2009-04-28 21:01         ` [PATCH v2] " Randy Dunlap
2009-04-28 21:40           ` J. Bruce Fields

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49F71F4A.3080908@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=matthew@wil.cx \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).