From mboxrd@z Thu Jan  1 00:00:00 1970
From: Boaz Harrosh <bharrosh@panasas.com>
Subject: Re: [PATCH] remove ->write_super call in generic_shutdown_super
Date: Thu, 30 Apr 2009 11:35:26 +0300
Message-ID: <49F962CE.8010907@panasas.com>
References: <20090428160026.GB26363@lst.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: Al Viro <viro@ZenIV.linux.org.uk>, Jan Kara <jack@suse.cz>,
	linux-fsdevel@vger.kernel.org
To: Christoph Hellwig <hch@lst.de>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from gw-ca.panasas.com ([209.116.51.66]:20248 "EHLO
	laguna.int.panasas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
	with ESMTP id S1751405AbZD3Ifi (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Thu, 30 Apr 2009 04:35:38 -0400
In-Reply-To: <20090428160026.GB26363@lst.de>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On 04/28/2009 07:00 PM, Christoph Hellwig wrote:
> We just did a full fs writeout using sync_filesystem before, and if
> that's not enough for the filesystem it can perform it's own writeout
> in ->put_super, which many filesystems already do.
> 
> Move a call to foofs_write_super into every foofs_put_super for now to
> guarantee identical behaviour until it's cleaned up by the individual
> filesystem maintainers.
> 
> Exceptions:
> 
>  - affs already has identical copy & pasted code at the beginning of
>    affs_put_super so no need to do it twice.
>  - xfs does the right thing without it and I have changes pending for
>    the xfs tree touching this are so I don't really need conflicts
>    here..
> 
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> 
<snip>
> ===================================================================
> --- linux-2.6.orig/fs/exofs/super.c	2009-04-28 17:45:49.232482198 +0200
> +++ linux-2.6/fs/exofs/super.c	2009-04-28 17:47:50.303050752 +0200
> @@ -258,6 +258,9 @@ static void exofs_put_super(struct super
>  	int num_pend;
>  	struct exofs_sb_info *sbi = sb->s_fs_info;
>  
> +	if (sb->s_dirt)
> +		exofs_write_super(sb);
> +
>  	/* make sure there are no pending commands */
>  	for (num_pend = atomic_read(&sbi->s_curr_pending); num_pend > 0;
>  	     num_pend = atomic_read(&sbi->s_curr_pending)) {

Ack-by: Boaz Harrosh <bharrosh@panasas.com>

<snip>

I'll put it on my TODO list to see if this can be removed, later.

Boaz