From: Randy Dunlap <rdunlap@infradead.org>
To: Kushagra Verma <kushagra765@outlook.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs: namei: fix two excess parameter description warnings
Date: Thu, 24 Nov 2022 18:51:48 -0800 [thread overview]
Message-ID: <49d0555b-7bd3-f8c7-f9ff-683d9720c6c7@infradead.org> (raw)
In-Reply-To: <HK0PR01MB28019953A3C47F9B4479D877F8069@HK0PR01MB2801.apcprd01.prod.exchangelabs.com>
On 11/17/22 04:28, Kushagra Verma wrote:
> While building the kernel documentation, two excess parameter description
> warnings appear:
> ./fs/namei.c:3589: warning: Excess function parameter 'dentry'
> description in 'vfs_tmpfile'
> ./fs/namei.c:3589: warning: Excess function parameter 'open_flag'
> description in 'vfs_tmpfile'
>
> Fix these warnings by changing 'dentry' to 'parentpath' in the parameter
> description and 'open_flag' to 'file' and change 'file' parameter's
> description accordingly.
>
> Signed-off-by: Kushagra Verma <kushagra765@outlook.com>
Tested-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> fs/namei.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/namei.c b/fs/namei.c
> index 578c2110df02..8e77e194fed5 100644
> --- a/fs/namei.c
> +++ b/fs/namei.c
> @@ -3571,9 +3571,9 @@ static int do_open(struct nameidata *nd,
> /**
> * vfs_tmpfile - create tmpfile
> * @mnt_userns: user namespace of the mount the inode was found from
> - * @dentry: pointer to dentry of the base directory
> + * @parentpath: pointer to dentry of the base directory
> * @mode: mode of the new tmpfile
> - * @open_flag: flags
> + * @file: file information
> *
> * Create a temporary file.
> *
--
~Randy
prev parent reply other threads:[~2022-11-25 2:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 12:28 [PATCH] fs: namei: fix two excess parameter description warnings Kushagra Verma
2022-11-25 2:51 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49d0555b-7bd3-f8c7-f9ff-683d9720c6c7@infradead.org \
--to=rdunlap@infradead.org \
--cc=kushagra765@outlook.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).