From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11EA0C77B73 for ; Sun, 16 Apr 2023 18:12:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229894AbjDPSMP (ORCPT ); Sun, 16 Apr 2023 14:12:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36028 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230070AbjDPSMB (ORCPT ); Sun, 16 Apr 2023 14:12:01 -0400 Received: from mail-yw1-x1134.google.com (mail-yw1-x1134.google.com [IPv6:2607:f8b0:4864:20::1134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E92A4269E for ; Sun, 16 Apr 2023 11:11:59 -0700 (PDT) Received: by mail-yw1-x1134.google.com with SMTP id 00721157ae682-552ae3e2cbeso25524267b3.13 for ; Sun, 16 Apr 2023 11:11:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1681668719; x=1684260719; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=LVJOhu0619OErP99xlPd4ihejbaRkAObRsbcnMFMEhQ=; b=woSRwUxuBadaYtz8Pla6HnY8OWT2Z6oLbv+IvJWJeFu7vl5IQgCqhJN9QW7j5/A8Ag Pnp0Moej9pT7JgW8tudH+yEzBUktIU4ioEkl0OO35HygM0IqCZWiph5WUYaiQP7GNxYE BcgYQV664/sYtXJroRKzXsITY7jTTPQUL/KzHaK/Iqz4JWfWRn/u4135QDVlSgHXlz1X X2iX0pcLJDn8kw1qlrq0JIqbpLnFN+aGhQn5GjLAP5/+v8T60MHc1c5lS46Ws3JX6Ie2 SR26zLTEOJMJNoPwgYukr9mQU3OL5Vks7gyt1HG1/eCYMNm7+uGDuWYwkrUYT2b06rn1 3ZmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681668719; x=1684260719; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LVJOhu0619OErP99xlPd4ihejbaRkAObRsbcnMFMEhQ=; b=QlPkBgZAl1RDU+YKSA/4A0NkPb4fsU4Jx+qAfOAirhGED9bjYroOqA0t26y9Dkqu9i cUufgAR8eaNGWoTeFqgVPDrQmSSSkBobw64FGxr5NorbvAQK6sXz7hsGCsFfqPucBMXs QAvhpaCt38qedj0ejYb7eWnssRaa37FGrFQXUU6/3jfxG5Z3PtkpSHu9DOvBPvQdHM5I EmbFle2mzkkl5zBTALQ1YQpL6teHqxJDI+RQ9YgjFe97Z59FX1PXobbobZA7rA7XXqf9 iQc9K53pgMzBnJ7z7TV1TSjUND28j7n86Y7xX2DNcIaxMibdOJ1Y7BnVhpSHw7QmGpqE 3gYQ== X-Gm-Message-State: AAQBX9cVuqwV1ZuZCdOW8c42y38n89aXEyepw1P0XyrxeR321esDLSdh QNXU82sNRDsTW1Bre66OvDM9AA== X-Google-Smtp-Source: AKy350bXCNF1WdQWBeDDtbhUdV1w3MyrNNNENEJZGG7rSYcaEKYB0vPKGwv0o3fMAWWvdfv66tXB5A== X-Received: by 2002:a81:6c56:0:b0:551:805d:6f7b with SMTP id h83-20020a816c56000000b00551805d6f7bmr7528281ywc.0.1681668719039; Sun, 16 Apr 2023 11:11:59 -0700 (PDT) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id l31-20020a81ad5f000000b00545a0818483sm2636333ywk.19.2023.04.16.11.11.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Apr 2023 11:11:58 -0700 (PDT) Date: Sun, 16 Apr 2023 11:11:49 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@ripple.attlocal.net To: Andrew Morton cc: Zi Yan , Zi Yan , "Matthew Wilcox (Oracle)" , Yang Shi , Yu Zhao , linux-mm@kvack.org, "Kirill A . Shutemov" , Ryan Roberts , =?ISO-8859-15?Q?Michal_Koutn=FD?= , Roman Gushchin , Zach O'Keefe , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v3 0/7] Split a folio to any lower order folios In-Reply-To: <20230404144727.e613116684dbd65a4b4745c1@linux-foundation.org> Message-ID: <49ee481e-452f-61c7-2da5-28de2cf3de2@google.com> References: <20230403201839.4097845-1-zi.yan@sent.com> <20230404144727.e613116684dbd65a4b4745c1@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, 4 Apr 2023, Andrew Morton wrote: > On Mon, 3 Apr 2023 16:18:32 -0400 Zi Yan wrote: > > > File folio supports any order and people would like to support flexible orders > > for anonymous folio[1] too. Currently, split_huge_page() only splits a huge > > page to order-0 pages, but splitting to orders higher than 0 is also useful. > > This patchset adds support for splitting a huge page to any lower order pages > > and uses it during file folio truncate operations. > > This series (and its v1 & v2) don't appear to have much in the way of > detailed review. As it's at v3 and has been fairly stable I'll queue > it up for some testing now, but I do ask that some reviewers go through > it please. Andrew, please don't let this series drift into 6.4-rc1. I've seen a bug or two (I'll point out in response to those patches), but overall I don't see what the justification for the series is: done because it could be done, it seems to me, but liable to add surprises. The cover letter says "splitting to orders higher than 0 is also useful", but it's not clear why; and the infrastructure provided seems unsuited to the one use provided - I'll say more on that truncation patch. Thanks, Hugh