From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: "Theodore Ts'o" <tytso@mit.edu>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
krh@redhat.com
Subject: Re: [PATCH 2/5] fs: Remove i_cindex from struct inode
Date: Thu, 21 May 2009 22:30:04 +0200 [thread overview]
Message-ID: <4A15B9CC.9030001@s5r6.in-berlin.de> (raw)
In-Reply-To: <1242936063-31689-3-git-send-email-tytso@mit.edu>
Theodore Ts'o wrote:
[...]
> The firewire driver does not need i_cindex in any fast path, so it's
> simple enough to calculate when it is needed, instead of wasting space
> in the inode structure.
>
> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
> Cc: krh@redhat.com
> Cc: stefanr@s5r6.in-berlin.de
> Cc: linux-fsdevel@vger.kernel.org
> ---
> drivers/ieee1394/dv1394.c | 5 +++--
> drivers/ieee1394/ieee1394_core.h | 5 ++++-
> fs/char_dev.c | 14 +++++++++++++-
> include/linux/cdev.h | 2 ++
> include/linux/fs.h | 1 -
> 5 files changed, 22 insertions(+), 5 deletions(-)
[...]
Acked-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
(No Ack needed from krh, he is concerned with drivers/firewire, not
really with driver/ieee1394. :-)
--
Stefan Richter
-=====-=-=== -=-= -==-=
http://arcgraph.de/sr/
prev parent reply other threads:[~2009-05-21 20:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-21 20:00 [RFC PATCH 0/5] Put struct inode on a diet Theodore Ts'o
2009-05-21 20:00 ` [PATCH 1/5] fs: i_flags and i_state in struct inode only need to be unsigned short Theodore Ts'o
2009-05-21 20:01 ` [PATCH 2/5] fs: Remove i_cindex from struct inode Theodore Ts'o
2009-05-21 20:01 ` [PATCH 3/5] fs: Slim down inode by only using an unsigned int for i_dnotify_mask Theodore Ts'o
2009-05-21 20:01 ` [PATCH 4/5] fs: Rearrange inode structure elements to avoid waste due to padding Theodore Ts'o
2009-05-21 20:01 ` [PATCH 5/5] Dump the inode structure (for debugging purposes only) Theodore Ts'o
2009-05-21 20:09 ` Matthew Wilcox
2009-05-21 20:28 ` Theodore Tso
2009-05-21 20:30 ` Stefan Richter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A15B9CC.9030001@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=krh@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).