From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH 25/20] sysfs: Only support removing emtpy sysfs directories. Date: Sun, 24 May 2009 12:24:12 +0900 Message-ID: <4A18BDDC.7060305@kernel.org> References: <1243109591-21611-5-git-send-email-ebiederm@xmission.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Andrew Morton , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Cornelia Huck , linux-fsdevel@vger.kernel.org, "Eric W. Biederman" To: "Eric W. Biederman" Return-path: Received: from hera.kernel.org ([140.211.167.34]:45777 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754598AbZEXDYe (ORCPT ); Sat, 23 May 2009 23:24:34 -0400 In-Reply-To: <1243109591-21611-5-git-send-email-ebiederm@xmission.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Eric W. Biederman wrote: > From: Eric W. Biederman > > I have looked and I have not found a single legitimate case today where > we remove sysfs directories with anything in them. The only case I have > found to date was a bug. It was a problem of ownership. The files in > the directory where not owned by the directory itself. Leaving open > the potential for double deletion of the directory contents. > > Signed-off-by: Eric W. Biederman For 21-24: Acked-by: Tejun Heo 25 maybe can be folded into the eariler in the series? Thanks. -- tejun