From mboxrd@z Thu Jan 1 00:00:00 1970 From: Artem Bityutskiy Subject: Re: [PATCH 0/11] Per-bdi writeback flusher threads v9 Date: Fri, 29 May 2009 19:02:51 +0300 Message-ID: <4A20072B.7050807@nokia.com> References: <1243511204-2328-1-git-send-email-jens.axboe@oracle.com> <4A1E9D0B.4090402@gmail.com> <4A1E9D8B.8020908@gmail.com> <1243542908.6645.104.camel@laptop> <4A20011E.7020900@nokia.com> <20090529155046.GH11363@kernel.dk> Reply-To: Artem.Bityutskiy@nokia.com Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Peter Zijlstra , "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "tytso@mit.edu" , "chris.mason@oracle.com" , "david@fromorbit.com" , "hch@infradead.org" , "akpm@linux-foundation.org" , "jack@suse.cz" , "yanmin_zhang@linux.intel.com" , "richard@rsk.demon.co.uk" , "damien.wyart@free.fr" To: Jens Axboe Return-path: Received: from smtp.nokia.com ([192.100.122.230]:31899 "EHLO mgw-mx03.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753483AbZE2QEi (ORCPT ); Fri, 29 May 2009 12:04:38 -0400 In-Reply-To: <20090529155046.GH11363@kernel.dk> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Jens Axboe wrote: >> diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c >> index 2349e2c..d1ac967 100644 >> --- a/fs/ubifs/super.c >> +++ b/fs/ubifs/super.c >> @@ -1929,6 +1929,9 @@ static int ubifs_fill_super(struct super_block= *sb, void *data, int silent) >> err =3D bdi_init(&c->bdi); >> if (err) >> goto out_close; >> + err =3D bdi_register(&c->bdi, NULL, "ubifs"); >> + if (err) >> + goto out_close; >=20 > Not quite right, you need to call bdi_destroy() if you have done the > init. Right, bdi_destroy() is already there for long time. I'm confused. > I committed this one this morning: >=20 > http://git.kernel.dk/?p=3Dlinux-2.6-block.git;a=3Dcommit;h=3D570a2fe1= df85741988ad0ca22aa406744436e281 Hmm, it is the same as my patch, but you do + err =3D bdi_register(&c->bdi); while I do + err =3D bdi_register(&c->bdi, NULL, "ubifs"); > But feel free to commit/submit to the ubifs tree directly, then it'll > disappear from my tree once it is merged. Yeah, I think it can go via my tree. I'd merge it at 2.6.31 window. This change does not depend on your work anyway. --=20 Best Regards, Artem Bityutskiy (=D0=90=D1=80=D1=82=D1=91=D0=BC =D0=91=D0=B8=D1=82=D1=8E= =D1=86=D0=BA=D0=B8=D0=B9) -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html