linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	tytso@mit.edu, chris.mason@oracle.com, david@fromorbit.com,
	hch@infradead.org, akpm@linux-foundation.org, jack@suse.cz,
	yanmin_zhang@linux.intel.com, richard@rsk.demon.co.uk,
	damien.wyart@free.fr
Subject: Re: [PATCH 0/11] Per-bdi writeback flusher threads v9
Date: Fri, 29 May 2009 19:20:19 +0300	[thread overview]
Message-ID: <4A200B43.40708@nokia.com> (raw)
In-Reply-To: <4A200846.5050109@gmail.com>

Artem Bityutskiy wrote:
> Jens Axboe wrote:
>> Hi,
>>
>> Here's the 9th version of the writeback patches. Changes since v8:
>>
>> - Fix a bdi_work on-stack allocation hang. I hope this fixes Ted's
>>   issue.
>> - Get rid of the explicit wait queues, we can just use wake_up_process()
>>   since it's just for that one task.
>> - Add separate "sync_supers" thread that makes sure that the dirty
>>   super blocks get written. We cannot safely do this from 
>> bdi_forker_task(),
>>   as that risks deadlocking on ->s_umount. Artem, I implemented this
>>   by doing the wake ups from a timer so that it would be easier for you
>>   to just deactivate the timer when there are no super blocks.
>>
>> For ease of patching, I've put the full diff here:
>>
>>   http://kernel.dk/writeback-v9.patch
>>
>> and also stored this in a writeback-v9 branch that will not change,
>> you can pull that into Linus tree from here:
>>
>>   git://git.kernel.dk/linux-2.6-block.git writeback-v9
> 
> I'm working with the above branch. Got the following twice.
> Not sure what triggers this, probably if I do nothing and
> cpufreq starts doing its magic, this is triggered.
> 
> And I'm not sure it has something to do with your changes,
> it is just that I saw this only with your tree. Please,
> ignore if this is not relevant.

Sorry, probably I shouldn't have reported this before looking
closer. I'll investigate this later and fine out whether it
is related to your work or not. Sorry for too early and probably
false alarm.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2009-05-29 16:21 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-28 11:46 [PATCH 0/11] Per-bdi writeback flusher threads v9 Jens Axboe
2009-05-28 11:46 ` [PATCH 01/11] ntfs: remove old debug check for dirty data in ntfs_put_super() Jens Axboe
2009-05-28 11:46 ` [PATCH 02/11] btrfs: properly register fs backing device Jens Axboe
2009-05-28 11:46 ` [PATCH 03/11] writeback: move dirty inodes from super_block to backing_dev_info Jens Axboe
2009-05-28 11:46 ` [PATCH 04/11] writeback: switch to per-bdi threads for flushing data Jens Axboe
2009-05-28 14:13   ` Artem Bityutskiy
2009-05-28 22:28     ` Jens Axboe
2009-05-28 11:46 ` [PATCH 05/11] writeback: get rid of pdflush completely Jens Axboe
2009-05-28 11:46 ` [PATCH 06/11] writeback: separate the flushing state/task from the bdi Jens Axboe
2009-05-28 11:46 ` [PATCH 07/11] writeback: support > 1 flusher thread per bdi Jens Axboe
2009-05-28 11:46 ` [PATCH 08/11] writeback: allow sleepy exit of default writeback task Jens Axboe
2009-05-28 11:46 ` [PATCH 09/11] writeback: add some debug inode list counters to bdi stats Jens Axboe
2009-05-28 11:46 ` [PATCH 10/11] writeback: add name to backing_dev_info Jens Axboe
2009-05-28 11:46 ` [PATCH 11/11] writeback: check for registered bdi in flusher add and inode dirty Jens Axboe
2009-05-28 13:56 ` [PATCH 0/11] Per-bdi writeback flusher threads v9 Peter Zijlstra
2009-05-28 22:28   ` Jens Axboe
2009-05-28 14:17 ` Artem Bityutskiy
2009-05-28 14:19   ` Artem Bityutskiy
2009-05-28 20:35     ` Peter Zijlstra
2009-05-28 22:27       ` Jens Axboe
2009-05-29 15:37       ` Artem Bityutskiy
2009-05-29 15:50         ` Jens Axboe
2009-05-29 16:02           ` Artem Bityutskiy
2009-05-29 17:07             ` Jens Axboe
2009-06-03  7:39               ` Artem Bityutskiy
2009-06-03  7:44                 ` Jens Axboe
2009-06-03  7:46                   ` Artem Bityutskiy
2009-06-03  7:50                     ` Jens Axboe
2009-06-03  7:54                       ` Artem Bityutskiy
2009-06-03  7:59                   ` Artem Bityutskiy
2009-06-03  8:07                     ` Jens Axboe
2009-05-28 14:41 ` Theodore Tso
2009-05-29 16:07 ` Artem Bityutskiy
2009-05-29 16:20   ` Artem Bityutskiy [this message]
2009-05-29 17:09     ` Jens Axboe
2009-06-03  8:11       ` Artem Bityutskiy
2009-05-29 17:08   ` Jens Axboe
2009-06-03 11:12 ` Artem Bityutskiy
2009-06-03 11:42   ` Jens Axboe
2009-06-04 15:20 ` Frederic Weisbecker
2009-06-04 19:07   ` Andrew Morton
2009-06-04 19:13     ` Frederic Weisbecker
2009-06-04 19:50       ` Jens Axboe
2009-06-04 20:10         ` Jens Axboe
2009-06-04 22:34           ` Frederic Weisbecker
2009-06-05 19:15             ` Jens Axboe
2009-06-05 21:14               ` Jan Kara
2009-06-06  0:18                 ` Chris Mason
2009-06-06  0:23                   ` Jan Kara
2009-06-06  1:06                     ` Frederic Weisbecker
2009-06-08  9:23                       ` Jens Axboe
2009-06-08 12:23                         ` Jan Kara
2009-06-08 12:28                           ` Jens Axboe
2009-06-08 13:01                             ` Jan Kara
2009-06-09 18:39                             ` Frederic Weisbecker
2009-06-06  1:00                 ` Frederic Weisbecker
2009-06-06  0:35               ` Frederic Weisbecker
2009-06-04 21:37         ` Frederic Weisbecker
2009-06-05  1:14   ` Zhang, Yanmin
2009-06-05 19:16     ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A200B43.40708@nokia.com \
    --to=artem.bityutskiy@nokia.com \
    --cc=akpm@linux-foundation.org \
    --cc=chris.mason@oracle.com \
    --cc=damien.wyart@free.fr \
    --cc=david@fromorbit.com \
    --cc=hch@infradead.org \
    --cc=jack@suse.cz \
    --cc=jens.axboe@oracle.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=richard@rsk.demon.co.uk \
    --cc=tytso@mit.edu \
    --cc=yanmin_zhang@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).