From mboxrd@z Thu Jan 1 00:00:00 1970 From: Artem Bityutskiy Subject: Re: [PATCH 0/11] Per-bdi writeback flusher threads v9 Date: Fri, 29 May 2009 19:20:19 +0300 Message-ID: <4A200B43.40708@nokia.com> References: <1243511204-2328-1-git-send-email-jens.axboe@oracle.com> <4A200846.5050109@gmail.com> Reply-To: Artem.Bityutskiy@nokia.com Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, tytso@mit.edu, chris.mason@oracle.com, david@fromorbit.com, hch@infradead.org, akpm@linux-foundation.org, jack@suse.cz, yanmin_zhang@linux.intel.com, richard@rsk.demon.co.uk, damien.wyart@free.fr To: Jens Axboe Return-path: Received: from smtp.nokia.com ([192.100.105.134]:23434 "EHLO mgw-mx09.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757472AbZE2QVb (ORCPT ); Fri, 29 May 2009 12:21:31 -0400 In-Reply-To: <4A200846.5050109@gmail.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Artem Bityutskiy wrote: > Jens Axboe wrote: >> Hi, >> >> Here's the 9th version of the writeback patches. Changes since v8: >> >> - Fix a bdi_work on-stack allocation hang. I hope this fixes Ted's >> issue. >> - Get rid of the explicit wait queues, we can just use wake_up_proce= ss() >> since it's just for that one task. >> - Add separate "sync_supers" thread that makes sure that the dirty >> super blocks get written. We cannot safely do this from=20 >> bdi_forker_task(), >> as that risks deadlocking on ->s_umount. Artem, I implemented this >> by doing the wake ups from a timer so that it would be easier for = you >> to just deactivate the timer when there are no super blocks. >> >> For ease of patching, I've put the full diff here: >> >> http://kernel.dk/writeback-v9.patch >> >> and also stored this in a writeback-v9 branch that will not change, >> you can pull that into Linus tree from here: >> >> git://git.kernel.dk/linux-2.6-block.git writeback-v9 >=20 > I'm working with the above branch. Got the following twice. > Not sure what triggers this, probably if I do nothing and > cpufreq starts doing its magic, this is triggered. >=20 > And I'm not sure it has something to do with your changes, > it is just that I saw this only with your tree. Please, > ignore if this is not relevant. Sorry, probably I shouldn't have reported this before looking closer. I'll investigate this later and fine out whether it is related to your work or not. Sorry for too early and probably false alarm. --=20 Best Regards, Artem Bityutskiy (=D0=90=D1=80=D1=82=D1=91=D0=BC =D0=91=D0=B8=D1=82=D1=8E= =D1=86=D0=BA=D0=B8=D0=B9) -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html