From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Sandeen Subject: Re: [PATCH] skip I_CLEAR state inodes Date: Mon, 01 Jun 2009 16:38:35 -0500 Message-ID: <4A244A5B.7070605@sandeen.net> References: <20090318170237.8F6C.61FB500B@jp.fujitsu.com> <20090323103846.GA16577@localhost> <20090324155655.2684.61FB500B@jp.fujitsu.com> <20090324074457.GA7745@localhost> <20090324120502.GC23439@duck.suse.cz> <20090324124001.GA25326@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Andrew Morton , LKML , Jan Kara , Masayoshi MIZUMA , "linux-fsdevel@vger.kernel.org" , "viro@zeniv.linux.org.uk" , Nick Piggin To: Wu Fengguang Return-path: Received: from mx2.redhat.com ([66.187.237.31]:34185 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751932AbZFAVip (ORCPT ); Mon, 1 Jun 2009 17:38:45 -0400 In-Reply-To: <20090324124001.GA25326@localhost> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Wu Fengguang wrote: > Add I_CLEAR tests to drop_pagecache_sb(), generic_sync_sb_inodes() and > add_dquot_ref(). > > clear_inode() will switch inode state from I_FREEING to I_CLEAR, > and do so _outside_ of inode_lock. So any I_FREEING testing is > incomplete without the testing of I_CLEAR. > > Masayoshi MIZUMA first discovered the bug in drop_pagecache_sb() and > Jan Kara reminds fixing the other two cases. Thanks! Is there a reason it's not done for __sync_single_inode as well? Jeff Layton asked the question and I'm following it up :) __sync_single_inode currently only tests I_FREEING, but I think we are safe because __sync_single_inode sets I_SYNC, and clear_inode waits for I_SYNC to be cleared before it changes I_STATE. On the other hand, testing I_CLEAR here probably would be safe anyway, and it'd be bonus points for consistency? Same basic question for generic_sync_sb_inodes, which has a BUG_ON(inode->i_state & I_FREEING), seems like this could check I_CLWAR as well? Thanks, -Eric