From mboxrd@z Thu Jan 1 00:00:00 1970 From: pravin shelar Subject: Re: [patch] add dentry revalidate to follow mount. Date: Tue, 09 Jun 2009 01:53:56 +0530 Message-ID: <4A2D735C.8090703@sun.com> References: <4A2D15AF.8090000@sun.com> <20090608141317.GJ8633@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; CHARSET=US-ASCII; format=flowed Content-Transfer-Encoding: 7BIT Cc: linux-fsdevel@vger.kernel.org To: Al Viro Return-path: Received: from sineb-mail-2.sun.com ([192.18.19.7]:40084 "EHLO sineb-mail-2.sun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752139AbZFHUPv (ORCPT ); Mon, 8 Jun 2009 16:15:51 -0400 Received: from fe-apac-05.sun.com (fe-apac-05.sun.com [192.18.19.176] (may be forged)) by sineb-mail-2.sun.com (8.13.6+Sun/8.12.9) with ESMTP id n58KFktf011272 for ; Mon, 8 Jun 2009 20:15:47 GMT Received: from conversion-daemon.mail-apac.sun.com by mail-apac.sun.com (Sun Java(tm) System Messaging Server 7u2-7.02 64bit (built Apr 16 2009)) id <0KKX00100S687Q00@mail-apac.sun.com> for linux-fsdevel@vger.kernel.org; Tue, 09 Jun 2009 04:15:46 +0800 (SGT) In-reply-to: <20090608141317.GJ8633@ZenIV.linux.org.uk> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Al Viro wrote: > On Mon, Jun 08, 2009 at 07:14:15PM +0530, pravin shelar wrote: >> Hi >> i have seen error in lustre while setting permission on fs root >> from a client. problem is permission are not getting propagated to >> other clients. >> >> this is because of do_lookup() call path which does not revalidate >> fs root dentry in follow_mount() >> >> attached patch adds revalidation call in follow_mount. > > ... and makes umount() of such thing impossible. NAK. That's not a solution. i am not sure how this patch could cause problem for umount. i have tested patch with nfs and it worked fine. can u elaborate what is problem? thanks, Pravin.