From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boaz Harrosh Subject: [PATCH version 2] exofs: Avoid using file_fsync() Date: Mon, 15 Jun 2009 20:07:44 +0300 Message-ID: <4A367FE0.4060508@panasas.com> References: <4A364D15.1080105@panasas.com> <20090615135044.GA2553@infradead.org> <4A367C51.4080305@panasas.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: open-osd mailing-list , linux-fsdevel , Al Viro To: Christoph Hellwig Return-path: Received: from ip67-152-220-66.z220-152-67.customer.algx.net ([67.152.220.66]:20022 "EHLO daytona.int.panasas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1759291AbZFORHo (ORCPT ); Mon, 15 Jun 2009 13:07:44 -0400 In-Reply-To: <4A367C51.4080305@panasas.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: I'll test with below patch and also with Christoph version which does: diff --git a/fs/exofs/file.c b/fs/exofs/file.c index 0c13650..2c8abdd 100644 --- a/fs/exofs/file.c +++ b/fs/exofs/file.c @@ -46,16 +46,10 @@ static int exofs_file_fsync(struct file *filp, struct dentry *dentry, int datasync) { int ret; - struct address_space *mapping = filp->f_mapping; struct inode * inode = dentry->d_inode; struct super_block * sb; - ret = filemap_write_and_wait(mapping); - if (ret) - return ret; - - /* sync the inode attributes */ - ret = write_inode_now(inode, 1); + ret = simple_fsync(filp, dentry, 1); /* This is a good place to write the sb */ /* TODO: Sechedule an sb-sync on create */ On top of the below one. See which one feels better. What should I test for? Thanks Boaz --- The use of file_fsync() in exofs_file_sync() is not necessary since it does some extra stuff not used by exofs. Open code just the parts that are currently needed. TODO: Farther optimization can be done to sync the sb only on inode update of new files, Usually the sb update is not needed in exofs. Signed-off-by: Boaz Harrosh --- fs/exofs/exofs.h | 3 +++ fs/exofs/file.c | 17 ++++++++++++----- fs/exofs/super.c | 2 +- 3 files changed, 16 insertions(+), 6 deletions(-) diff --git a/fs/exofs/exofs.h b/fs/exofs/exofs.h index 0fd4c78..5d15512 100644 --- a/fs/exofs/exofs.h +++ b/fs/exofs/exofs.h @@ -156,6 +156,9 @@ ino_t exofs_parent_ino(struct dentry *child); int exofs_set_link(struct inode *, struct exofs_dir_entry *, struct page *, struct inode *); +/* super.c */ +int exofs_sync_fs(struct super_block *sb, int wait); + /********************* * operation vectors * *********************/ diff --git a/fs/exofs/file.c b/fs/exofs/file.c index 6ed7fe4..0c13650 100644 --- a/fs/exofs/file.c +++ b/fs/exofs/file.c @@ -47,16 +47,23 @@ static int exofs_file_fsync(struct file *filp, struct dentry *dentry, { int ret; struct address_space *mapping = filp->f_mapping; + struct inode * inode = dentry->d_inode; + struct super_block * sb; ret = filemap_write_and_wait(mapping); if (ret) return ret; - /*Note: file_fsync below also calles sync_blockdev, which is a no-op - * for exofs, but other then that it does sync_inode and - * sync_superblock which is what we need here. - */ - return file_fsync(filp, dentry, datasync); + /* sync the inode attributes */ + ret = write_inode_now(inode, 1); + + /* This is a good place to write the sb */ + /* TODO: Sechedule an sb-sync on create */ + sb = inode->i_sb; + if (sb->s_dirt) + exofs_sync_fs(sb, 1); + + return ret; } static int exofs_flush(struct file *file, fl_owner_t id) diff --git a/fs/exofs/super.c b/fs/exofs/super.c index 8216c5b..e4fa0ce 100644 --- a/fs/exofs/super.c +++ b/fs/exofs/super.c @@ -200,7 +200,7 @@ static const struct export_operations exofs_export_ops; /* * Write the superblock to the OSD */ -static int exofs_sync_fs(struct super_block *sb, int wait) +int exofs_sync_fs(struct super_block *sb, int wait) { struct exofs_sb_info *sbi; struct exofs_fscb *fscb; -- 1.6.2.1