From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeff Garzik <jeff@garzik.org>
Subject: Re: [PATCH] exofs: Avoid using file_fsync()
Date: Mon, 15 Jun 2009 13:21:00 -0400
Message-ID: <4A3682FC.6010000@garzik.org>
References: <4A364D15.1080105@panasas.com> <20090615135044.GA2553@infradead.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Boaz Harrosh <bharrosh@panasas.com>,
	open-osd mailing-list <osd-dev@open-osd.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Al Viro <viro@ZenIV.linux.org.uk>
To: Christoph Hellwig <hch@infradead.org>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from srv5.dvmed.net ([207.36.208.214]:45154 "EHLO mail.dvmed.net"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752090AbZFORVV (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Mon, 15 Jun 2009 13:21:21 -0400
In-Reply-To: <20090615135044.GA2553@infradead.org>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

Christoph Hellwig wrote:
> On Mon, Jun 15, 2009 at 04:31:01PM +0300, Boaz Harrosh wrote:
>> +	ret = write_inode_now(inode, 0);
> 
> You shouldn't need a write_inode_now, but rather just a similar
> sync_inode call as in ext2 or the new simple_fsync as data was
> already written by the VFS.

And then there is the issue of needing to flush the storage device, 
otherwise fsync(2) does not provide relevant guarantees...

	Jeff