From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marco Subject: Re: Re: [PATCH 14/14] Pramfs: XIP Operations Date: Wed, 17 Jun 2009 18:57:48 +0200 Message-ID: <4A39208C.3010801@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: Linux Embedded , Linux Kernel , Daniel Walker To: Linux FS Devel Return-path: Sender: linux-embedded-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Jared Hulbert wrote: > > I know. It wasn't my intention to introduce it but as I said in my > > first patch I've done a porting of this code from 2.6.10 and to > > remove it I need time to analyze well the code to avoid deadlock and > > so on. If someone would like to help me I'd really appreciate it. > > However I see the use of BKL even in other recent "mainlined" fs as > > ext4, so I preferred to move the porting effort on other areas. > > However it's the first item on my todo list. > Why do you need the lock in pram_find_and_alloc_blocks() to begin > with? Why wouldn't a mutex work? It's not impossible to use a mutex, but as I said it's inherited from code written for 2.6.10. This function works as pram_get_and_update_block works. Marco