From mboxrd@z Thu Jan 1 00:00:00 1970 From: "H. Peter Anvin" Subject: Re: [PATCH 1/2] vfs: make real_lookup do dentry revalidation with i_mutex held Date: Thu, 25 Jun 2009 06:41:01 -0700 Message-ID: <4A437E6D.3030207@zytor.com> References: <1237493790-5665-1-git-send-email-sage@newdream.net> <49C85E3E.7030505@themaw.net> <49C85F0A.9030409@themaw.net> <49C9CA5A.5080809@themaw.net> <49CA579B.5080307@themaw.net> <49CAE3DB.3030909@themaw.net> <1238063926.23853.15.camel@zeus.themaw.net> <49D56DD5.80707@themaw.net> <4A4023CF.7040203@themaw.net> <4A4040AA.5030108@zytor.com> <4A432569.7050404@themaw.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Sage Weil , linux-fsdevel , Christoph Hellwig , akpm@linux-foundation.org, Al Viro , Yehuda Sadeh , Jon Masters To: Ian Kent Return-path: Received: from terminus.zytor.com ([198.137.202.10]:47433 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751411AbZFYNvI (ORCPT ); Thu, 25 Jun 2009 09:51:08 -0400 In-Reply-To: <4A432569.7050404@themaw.net> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Ian Kent wrote: > > We probably have to accept that people doing insmod with a specific > path are going to have a problem and they shouldn't use that method > anyway. But, AFAICS using a MODULE_ALIAS() in the kernel module will > allow for the name change but doesn't seem to take account of the > directory name change. Is that correct? > I'm not sure what that's supposed to mean. Generally the directory a module appears in doesn't matter. > There are those that may have an alias in the module-init-tools > configuration as well. But we need get rid of that practice as well as, > for a long time now, the alias hasn't been needed. > > Anyone have any thoughts how we might better handle these difficulties? I suspect the MODULE_ALIAS should just do it. -hpa -- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf.