From mboxrd@z Thu Jan  1 00:00:00 1970
From: Artem Bityutskiy <dedekind1@gmail.com>
Subject: Re: [PATCH 05/10] writeback: support > 1 flusher thread per bdi
Date: Mon, 06 Jul 2009 15:18:21 +0300
Message-ID: <4A51EB8D.1070300@gmail.com>
References: <1245926523-21959-1-git-send-email-jens.axboe@oracle.com> <1245926523-21959-6-git-send-email-jens.axboe@oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8;
	format=flowed
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	chris.mason@oracle.com, david@fromorbit.com, hch@infradead.org,
	akpm@linux-foundation.org, jack@suse.cz,
	yanmin_zhang@linux.intel.com, richard@rsk.demon.co.uk,
	damien.wyart@free.fr, fweisbec@gmail.com, Alan.Brunelle@hp.com
To: Jens Axboe <jens.axboe@oracle.com>
Return-path: <linux-kernel-owner+glk-linux-kernel-3=40m.gmane.org-S1756950AbZGFMUB@vger.kernel.org>
In-Reply-To: <1245926523-21959-6-git-send-email-jens.axboe@oracle.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

Jens Axboe wrote:
> +static struct bdi_work *bdi_alloc_work(struct super_block *sb, long =
nr_pages,
> +				       enum writeback_sync_modes sync_mode)
> +{
> +	struct bdi_work *work;
> +
> +	work =3D kmalloc(sizeof(*work), GFP_ATOMIC);
> +	if (work)
> +		bdi_work_init(work, sb, nr_pages, sync_mode);
> =20
> -	wb_start_writeback(&bdi->wb, sb, nr_pages, sync_mode);
> +	return work;
> +}

Since the caller of this function handles kmalloc failure gracefully,
should we also pass __GFP_NOWARN flag to kmalloc() here, in order to
avoid large and scary no-memory complaints?

--=20
Best Regards,
Artem Bityutskiy (=D0=90=D1=80=D1=82=D1=91=D0=BC =D0=91=D0=B8=D1=82=D1=8E=
=D1=86=D0=BA=D0=B8=D0=B9)