From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boaz Harrosh Subject: Re: [PATCH v3 04/18] EXOFS: do not manipulate s_dirt directly Date: Sun, 12 Jul 2009 12:53:47 +0300 Message-ID: <4A59B2AB.9010900@panasas.com> References: <20090709084822.12122.79749.sendpatchset@localhost.localdomain> <20090709084849.12122.23929.sendpatchset@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Al Viro , Jens Axboe , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Jeff Garzik To: Artem Bityutskiy Return-path: In-Reply-To: <20090709084849.12122.23929.sendpatchset@localhost.localdomain> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On 07/09/2009 11:48 AM, Artem Bityutskiy wrote: > ... use new VFS helpers instead. > > Signed-off-by: Artem Bityutskiy > Acked-by: Boaz Harrosh Hi Artem. Linus has pulled the exofs tree for 2.6.31-rc3 if you sync with it you'll find one more simple call site for is_sb_dirty(sb). (See below) Thanks Boaz --- git diff --stat -p fs/exofs/file.c fs/exofs/file.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/exofs/file.c b/fs/exofs/file.c index 839b9dc..be38834 100644 --- a/fs/exofs/file.c +++ b/fs/exofs/file.c @@ -58,7 +58,7 @@ static int exofs_file_fsync(struct file *filp, struct dentry *dentry, /* This is a good place to write the sb */ /* TODO: Sechedule an sb-sync on create */ sb = inode->i_sb; - if (sb->s_dirt) + if (is_sb_dirty(sb)) exofs_sync_fs(sb, 1); return ret;