From: Adrian Hunter <adrian.hunter@nokia.com>
To: "Bityutskiy Artem (Nokia-D/Helsinki)" <Artem.Bityutskiy@nokia.com>
Cc: Artem Bityutskiy <dedekind1@gmail.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH] UBIFS: kill BKL
Date: Mon, 20 Jul 2009 09:35:28 +0300 [thread overview]
Message-ID: <4A641030.8090402@nokia.com> (raw)
In-Reply-To: <4A640EBA.2070209@nokia.com>
Bityutskiy Artem (Nokia-D/Helsinki) wrote:
> On 07/20/2009 09:16 AM, Hunter Adrian (Nokia-D/Helsinki) wrote:
>> Artem Bityutskiy wrote:
>>> From: Artem Bityutskiy<Artem.Bityutskiy@nokia.com>
>>>
>>> The BKL was pushed down from VFS to the file-systems. It used
>>> to serialize mount/unmount/remount. UBIFS must be safe if several
>>> file-systems are mounted/unmounted/re-mounted at the same time,
>>> so kill kick the BKL out of UBIFS.
>>>
>>> Signed-off-by: Artem Bityutskiy<Artem.Bityutskiy@nokia.com>
>>> ---
>> Looks like protection is always provided by sb->s_umount
>
> Err, then what would be a possible reason we would need BKL?
Say if we had used BKL instead of c->umount_mutex.
i.e. if we had relied on BKL in some other code
to provide synchronisation with unmounting/remounting etc
next prev parent reply other threads:[~2009-07-20 6:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-19 10:55 [PATCH] UBIFS: kill BKL Artem Bityutskiy
2009-07-20 6:16 ` Adrian Hunter
2009-07-20 6:27 ` Artem Bityutskiy
2009-07-20 6:29 ` Artem Bityutskiy
2009-07-20 6:35 ` Adrian Hunter [this message]
2009-07-20 10:26 ` Artem Bityutskiy
2009-07-20 12:51 ` Christoph Hellwig
2009-07-20 13:22 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A641030.8090402@nokia.com \
--to=adrian.hunter@nokia.com \
--cc=Artem.Bityutskiy@nokia.com \
--cc=dedekind1@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).