From mboxrd@z Thu Jan 1 00:00:00 1970 From: Artem Bityutskiy Subject: Re: [patch 03/11] fs: introduce new truncate sequence Date: Wed, 26 Aug 2009 10:40:32 +0300 Message-ID: <4A94E6F0.1080402@gmail.com> References: <20090820163504.131529718@suse.de> <20090820164050.705502985@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Andrew Morton , linux-fsdevel@vger.kernel.org, Christoph Hellwig To: npiggin@suse.de Return-path: Received: from smtp.nokia.com ([192.100.122.230]:40588 "EHLO mgw-mx03.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756210AbZHZHlG (ORCPT ); Wed, 26 Aug 2009 03:41:06 -0400 In-Reply-To: <20090820164050.705502985@suse.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Hi, just minor suggestions. On 08/20/2009 07:35 PM, npiggin@suse.de wrote: > +/** > + * generic_setattr - copy simple metadata updates into the generic i= node > + * @inode: the inode to be updated > + * @attr: the new attributes > + * > + * generic_setattr must be called with i_mutex held. > + * > + * generic_setattr updates the inode's metadata with that specified > + * in attr. Noticably missing is inode size update, which is more co= mplex > + * as it requires pagecache updates. See simple_setsize. > + * > + * The inode is not marked as dirty after this operation. The ration= ale is > + * that for "simple" filesystems, the struct inode is the inode stor= age. > + * The caller is free to mark the inode dirty afterwards if needed. > + */ > +void generic_setattr(struct inode *inode, struct iattr *attr) > { Could you use 'const' for attr here? > +/* > + * note this function is deprecated, the new truncate sequence shoul= d be > + * used instead -- see eg. simple_setsize, generic_setattr. > + */ > +int inode_setattr(struct inode *inode, struct iattr * attr) > +{ And for 'attr' here, as well as do a tiny clean-up and us '*attr', not = '* attr'. :-) --=20 Best Regards, Artem Bityutskiy (=D0=90=D1=80=D1=82=D1=91=D0=BC =D0=91=D0=B8=D1=82=D1=8E= =D1=86=D0=BA=D0=B8=D0=B9) -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html