From mboxrd@z Thu Jan 1 00:00:00 1970 From: Artem Bityutskiy Subject: Re: [PATCH 1/8] writeback: get rid of generic_sync_sb_inodes() export Date: Tue, 08 Sep 2009 13:27:54 +0300 Message-ID: <4AA631AA.6000803@gmail.com> References: <1252401791-22463-1-git-send-email-jens.axboe@oracle.com> <1252401791-22463-2-git-send-email-jens.axboe@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, chris.mason@oracle.com, david@fromorbit.com, hch@infradead.org, akpm@linux-foundation.org, jack@suse.cz To: Jens Axboe Return-path: Received: from smtp.nokia.com ([192.100.122.230]:55804 "EHLO mgw-mx03.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753788AbZIHK3L (ORCPT ); Tue, 8 Sep 2009 06:29:11 -0400 In-Reply-To: <1252401791-22463-2-git-send-email-jens.axboe@oracle.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Hi Jens, On 09/08/2009 12:23 PM, Jens Axboe wrote: > int i, err; > struct ubifs_info *c =3D sb->s_fs_info; > - struct writeback_control wbc =3D { > - .sync_mode =3D WB_SYNC_ALL, > - .range_start =3D 0, > - .range_end =3D LLONG_MAX, > - .nr_to_write =3D LONG_MAX, > - }; > > /* > * Zero @wait is just an advisory thing to help the file system sh= ove > @@ -462,7 +456,7 @@ static int ubifs_sync_fs(struct super_block *sb, = int wait) > * the user be able to get more accurate results of 'statfs()' aft= er > * they synchronize the file system. > */ > - generic_sync_sb_inodes(sb,&wbc); > + sync_inodes_sb(sb); This call is unnecessary and I've removed it and the patch is sitting i= n linux-next for long time: http://git.infradead.org/ubifs-2.6.git/commit/887ee17117fd23e962332b353= d250ac9e090b20f Stephen e-mailed about the conflict recently. Could we please resolve t= he conflict? I guess if you pick up my patch then git will be able to reso= lve stuff automatically. --=20 Best Regards, Artem Bityutskiy (=D0=90=D1=80=D1=82=D1=91=D0=BC =D0=91=D0=B8=D1=82=D1=8E= =D1=86=D0=BA=D0=B8=D0=B9) -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html