From: Tyler Hicks <tyhicks@linux.vnet.ibm.com>
To: Christoph Hellwig <hch@lst.de>
Cc: kirkland@canonical.com, linux-fsdevel@vger.kernel.org
Subject: Re: truncate in ecryptfs
Date: Wed, 14 Oct 2009 10:37:26 -0500 [thread overview]
Message-ID: <4AD5F036.5030209@linux.vnet.ibm.com> (raw)
In-Reply-To: <20091014151221.GA18371@lst.de>
On 10/14/2009 10:12 AM, Christoph Hellwig wrote:
> It looks like ecryptfs calls vmtruncate directly on the lower filesystem,
> which is quite wrong. Vmtruncate is only a helper for the filesystem,
> and while most filesystems end up calling vmtruncate from their
> ->setattr implementation if ATTR_SIZE is set there are many that require
> additional work. I think ecryptfs needs to got through notify_change()
> / ->setattr if it wants truncate to work reliably and without silent
> corruption or leaking blocks on a variety of filesystems.
Thanks Christoph! I agree and will write up a patch shortly. I also
opened a bug to track the progress:
https://bugs.launchpad.net/ecryptfs/+bug/451368
Tyler
next prev parent reply other threads:[~2009-10-14 15:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-14 15:12 truncate in ecryptfs Christoph Hellwig
2009-10-14 15:37 ` Tyler Hicks [this message]
2009-10-15 4:19 ` [PATCH] eCryptfs: Use notify_change for truncating lower inodes Tyler Hicks
2009-10-15 16:55 ` Dustin Kirkland
2009-10-25 7:22 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AD5F036.5030209@linux.vnet.ibm.com \
--to=tyhicks@linux.vnet.ibm.com \
--cc=hch@lst.de \
--cc=kirkland@canonical.com \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).