From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zach Brown Subject: Re: [PATCH 3/8] aio: add an interface to submit aio from the kernel Date: Mon, 26 Oct 2009 15:21:07 -0700 Message-ID: <4AE620D3.10405@oracle.com> References: <1256243157-16667-1-git-send-email-zach.brown@oracle.com> <1256243157-16667-2-git-send-email-zach.brown@oracle.com> <1256243157-16667-3-git-send-email-zach.brown@oracle.com> <1256243157-16667-4-git-send-email-zach.brown@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org To: Jeff Moyer Return-path: Received: from rcsinet11.oracle.com ([148.87.113.123]:35339 "EHLO rgminet11.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753530AbZJZWW6 (ORCPT ); Mon, 26 Oct 2009 18:22:58 -0400 In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: > Why isn't this just a static inline in a header, like the > io_prep_pread/pwrite methods in libaio.h? Not a big deal, just curious. Honestly, I didn't give it much thought -- I just threw it together this way. I'd be happy either way, though I guess I tend to prefer to avoid inlining. >> +int aio_kernel_submit(struct kiocb *iocb) > > Why are you limiting this to just 1 iocb at a time? Well, the current user will only be issuing one at a time. We can worry about adding that complexity when someone can justify it :). - z