From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zach Brown Subject: Re: [PATCH 4/8] aio: add aio_read_pages and aio_write_pages Date: Mon, 26 Oct 2009 15:22:55 -0700 Message-ID: <4AE6213F.6040900@oracle.com> References: <1256243157-16667-1-git-send-email-zach.brown@oracle.com> <1256243157-16667-2-git-send-email-zach.brown@oracle.com> <1256243157-16667-3-git-send-email-zach.brown@oracle.com> <1256243157-16667-4-git-send-email-zach.brown@oracle.com> <1256243157-16667-5-git-send-email-zach.brown@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org To: Jeff Moyer Return-path: Received: from rcsinet12.oracle.com ([148.87.113.124]:50621 "EHLO rgminet12.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753596AbZJZWXK (ORCPT ); Mon, 26 Oct 2009 18:23:10 -0400 In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: > I question the merits of adding commands to the aio_abi that cannot be > called from userspace. However, I don't know how else you would keep > things consistent. I guess we live with it. I didn't like it either. I can give this some more thought. > Actually, I didn't see code in the patch to prevent userspace from > issuing such commands. Shouldn't we check for that and spit an error? > It sounds like a security risk if we don't. See, that's why we keep you around! Yes, that's one of the things we have to fix before it can be merged. - z