From mboxrd@z Thu Jan  1 00:00:00 1970
From: Zach Brown <zach.brown@oracle.com>
Subject: Re: [PATCH 6/8] dio: add an entry point which takes pages
Date: Tue, 27 Oct 2009 10:50:37 -0700
Message-ID: <4AE732ED.7060502@oracle.com>
References: <1256243157-16667-1-git-send-email-zach.brown@oracle.com>	<1256243157-16667-2-git-send-email-zach.brown@oracle.com>	<1256243157-16667-3-git-send-email-zach.brown@oracle.com>	<1256243157-16667-4-git-send-email-zach.brown@oracle.com>	<1256243157-16667-5-git-send-email-zach.brown@oracle.com>	<1256243157-16667-6-git-send-email-zach.brown@oracle.com>	<1256243157-16667-7-git-send-email-zach.brown@oracle.com> <x49vdi025wp.fsf@segfault.boston.devel.redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: linux-fsdevel@vger.kernel.org
To: Jeff Moyer <jmoyer@redhat.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from rcsinet12.oracle.com ([148.87.113.124]:18078 "EHLO
	rgminet12.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756395AbZJ0Rwx (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Tue, 27 Oct 2009 13:52:53 -0400
In-Reply-To: <x49vdi025wp.fsf@segfault.boston.devel.redhat.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>


>> +	if (dio->is_async && dio->rw == READ && dio->curr_user_address)
> 
> Any chance we can factor this check out into a macro or some such thing?
> It's repeated several times.

Yeah.  I'm also nervous about overloading curr_user_address for this.
It was expedient, but it feels unnecessarily fragile.

- z