From mboxrd@z Thu Jan  1 00:00:00 1970
From: Coly Li <coly.li@suse.de>
Subject: Re: [PATCH 14/27] BKL: Remove BKL from cramfs
Date: Mon, 02 Nov 2009 18:46:20 +0800
Message-ID: <4AEEB87C.8060106@suse.de>
References: <1257156307-24175-1-git-send-email-jblunck@suse.de> <1257156307-24175-15-git-send-email-jblunck@suse.de>
Reply-To: coly.li@suse.de
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: linux-fsdevel@vger.kernel.org, Matthew Wilcox <matthew@wil.cx>,
	linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	David VomLehn <dvomlehn@cisco.com>,
	Al Viro <viro@zeniv.linux.org.uk>
To: Jan Blunck <jblunck@suse.de>
Return-path: <linux-kernel-owner+glk-linux-kernel-3=40m.gmane.org-S1754462AbZKBKj3@vger.kernel.org>
In-Reply-To: <1257156307-24175-15-git-send-email-jblunck@suse.de>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

Acked-by: Coly Li <coly.li@suse.de>

On 2009=E5=B9=B411=E6=9C=8802=E6=97=A5 18:04, Jan Blunck Wrote:
> BKL is only used in fill_super. It is safe to remove it.
>=20
> Signed-off-by: Jan Blunck <jblunck@suse.de>
> ---
>  fs/cramfs/inode.c |    8 +-------
>  1 files changed, 1 insertions(+), 7 deletions(-)
>=20
> diff --git a/fs/cramfs/inode.c b/fs/cramfs/inode.c
> index 13e696a..dd3634e 100644
> --- a/fs/cramfs/inode.c
> +++ b/fs/cramfs/inode.c
> @@ -227,15 +227,11 @@ static int cramfs_fill_super(struct super_block=
 *sb, void *data, int silent)
>  	struct cramfs_sb_info *sbi;
>  	struct inode *root;
> =20
> -	lock_kernel();
> -
>  	sb->s_flags |=3D MS_RDONLY;
> =20
>  	sbi =3D kzalloc(sizeof(struct cramfs_sb_info), GFP_KERNEL);
> -	if (!sbi) {
> -		unlock_kernel();
> +	if (!sbi)
>  		return -ENOMEM;
> -	}
>  	sb->s_fs_info =3D sbi;
> =20
>  	/* Invalidate the read buffers on mount: think disk change.. */
> @@ -312,12 +308,10 @@ static int cramfs_fill_super(struct super_block=
 *sb, void *data, int silent)
>  		iput(root);
>  		goto out;
>  	}
> -	unlock_kernel();
>  	return 0;
>  out:
>  	kfree(sbi);
>  	sb->s_fs_info =3D NULL;
> -	unlock_kernel();
>  	return -EINVAL;
>  }
> =20

--=20
Coly Li
SuSE Labs