Re: [PATCH 20/27] BKL: Remove BKL from minix

[Coly Li <coly.li@suse.de>]

Acked-by: Coly Li <coly.li@suse.de>

On 2009年11月02日 18:05, Jan Blunck Wrote:
> BKL is only used in fill_super. It is safe to remove it.
> 
> Signed-off-by: Jan Blunck <jblunck@suse.de>
> ---
>  fs/minix/inode.c |    8 +-------
>  1 files changed, 1 insertions(+), 7 deletions(-)
> 
> diff --git a/fs/minix/inode.c b/fs/minix/inode.c
> index b8aa0a6..74ea82d 100644
> --- a/fs/minix/inode.c
> +++ b/fs/minix/inode.c
> @@ -147,13 +147,9 @@ static int minix_fill_super(struct super_block *s, void *data, int silent)
>  	struct minix_sb_info *sbi;
>  	int ret = -EINVAL;
>  
> -	lock_kernel();
> -
>  	sbi = kzalloc(sizeof(struct minix_sb_info), GFP_KERNEL);
> -	if (!sbi) {
> -		unlock_kernel();
> +	if (!sbi)
>  		return -ENOMEM;
> -	}
>  	s->s_fs_info = sbi;
>  
>  	BUILD_BUG_ON(32 != sizeof (struct minix_inode));
> @@ -269,7 +265,6 @@ static int minix_fill_super(struct super_block *s, void *data, int silent)
>   	else if (sbi->s_mount_state & MINIX_ERROR_FS)
>  		printk("MINIX-fs: mounting file system with errors, "
>  			"running fsck is recommended\n");
> -	unlock_kernel();
>  	return 0;
>  
>  out_iput:
> @@ -319,7 +314,6 @@ out_bad_sb:
>  out:
>  	s->s_fs_info = NULL;
>  	kfree(sbi);
> -	unlock_kernel();
>  	return ret;
>  }
>  

-- 
Coly Li
SuSE Labs