From mboxrd@z Thu Jan 1 00:00:00 1970 From: Coly Li Subject: Re: [PATCH 20/27] BKL: Remove BKL from minix Date: Mon, 02 Nov 2009 18:46:38 +0800 Message-ID: <4AEEB88E.6000008@suse.de> References: <1257156307-24175-1-git-send-email-jblunck@suse.de> <1257156307-24175-21-git-send-email-jblunck@suse.de> Reply-To: coly.li@suse.de Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-fsdevel@vger.kernel.org, Matthew Wilcox , linux-kernel@vger.kernel.org, Al Viro , Andrew Morton , Gertjan van Wingerde To: Jan Blunck Return-path: In-Reply-To: <1257156307-24175-21-git-send-email-jblunck@suse.de> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Acked-by: Coly Li On 2009=E5=B9=B411=E6=9C=8802=E6=97=A5 18:05, Jan Blunck Wrote: > BKL is only used in fill_super. It is safe to remove it. >=20 > Signed-off-by: Jan Blunck > --- > fs/minix/inode.c | 8 +------- > 1 files changed, 1 insertions(+), 7 deletions(-) >=20 > diff --git a/fs/minix/inode.c b/fs/minix/inode.c > index b8aa0a6..74ea82d 100644 > --- a/fs/minix/inode.c > +++ b/fs/minix/inode.c > @@ -147,13 +147,9 @@ static int minix_fill_super(struct super_block *= s, void *data, int silent) > struct minix_sb_info *sbi; > int ret =3D -EINVAL; > =20 > - lock_kernel(); > - > sbi =3D kzalloc(sizeof(struct minix_sb_info), GFP_KERNEL); > - if (!sbi) { > - unlock_kernel(); > + if (!sbi) > return -ENOMEM; > - } > s->s_fs_info =3D sbi; > =20 > BUILD_BUG_ON(32 !=3D sizeof (struct minix_inode)); > @@ -269,7 +265,6 @@ static int minix_fill_super(struct super_block *s= , void *data, int silent) > else if (sbi->s_mount_state & MINIX_ERROR_FS) > printk("MINIX-fs: mounting file system with errors, " > "running fsck is recommended\n"); > - unlock_kernel(); > return 0; > =20 > out_iput: > @@ -319,7 +314,6 @@ out_bad_sb: > out: > s->s_fs_info =3D NULL; > kfree(sbi); > - unlock_kernel(); > return ret; > } > =20 --=20 Coly Li SuSE Labs