From mboxrd@z Thu Jan 1 00:00:00 1970 From: Coly Li Subject: Re: [PATCH 16/27] BKL: Remove BKL from efs Date: Mon, 02 Nov 2009 18:47:00 +0800 Message-ID: <4AEEB8A4.8000700@suse.de> References: <1257156307-24175-1-git-send-email-jblunck@suse.de> <1257156307-24175-17-git-send-email-jblunck@suse.de> Reply-To: coly.li@suse.de Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-fsdevel@vger.kernel.org, Matthew Wilcox , linux-kernel@vger.kernel.org, Andrew Morton To: Jan Blunck Return-path: Received: from cantor.suse.de ([195.135.220.2]:48691 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754400AbZKBKkD (ORCPT ); Mon, 2 Nov 2009 05:40:03 -0500 In-Reply-To: <1257156307-24175-17-git-send-email-jblunck@suse.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Acked-by: Coly Li On 2009=E5=B9=B411=E6=9C=8802=E6=97=A5 18:04, Jan Blunck Wrote: > BKL is only used in fill_super. It is safe to remove it. >=20 > Signed-off-by: Jan Blunck > --- > fs/efs/super.c | 10 ++-------- > 1 files changed, 2 insertions(+), 8 deletions(-) >=20 > diff --git a/fs/efs/super.c b/fs/efs/super.c > index 0981141..f049428 100644 > --- a/fs/efs/super.c > +++ b/fs/efs/super.c > @@ -249,13 +249,9 @@ static int efs_fill_super(struct super_block *s,= void *d, int silent) > struct inode *root; > int ret =3D -EINVAL; > =20 > - lock_kernel(); > - > - sb =3D kzalloc(sizeof(struct efs_sb_info), GFP_KERNEL); > - if (!sb) { > - unlock_kernel(); > + sb =3D kzalloc(sizeof(struct efs_sb_info), GFP_KERNEL); > + if (!sb) > return -ENOMEM; > - } > s->s_fs_info =3D sb; > =20 > s->s_magic =3D EFS_SUPER_MAGIC; > @@ -323,14 +319,12 @@ static int efs_fill_super(struct super_block *s= , void *d, int silent) > goto out_no_fs; > } > =20 > - unlock_kernel(); > return 0; > =20 > out_no_fs_ul: > out_no_fs: > s->s_fs_info =3D NULL; > kfree(sb); > - unlock_kernel(); > return ret; > } > =20 --=20 Coly Li SuSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html