From: Phillip Lougher <phillip@lougher.demon.co.uk>
To: Phillip Lougher <phillip@lougher.demon.co.uk>
Cc: Andrew Morton <akpm@linux-foundation.org>,
jblunck@suse.de, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, matthew@wil.cx,
viro@zeniv.linux.org.uk
Subject: Re: BKL: Remove BKL from Squashfs
Date: Tue, 10 Nov 2009 21:37:40 +0000 [thread overview]
Message-ID: <4AF9DD24.8060501@lougher.demon.co.uk> (raw)
In-Reply-To: <4AF9D6EE.1070205@lougher.demon.co.uk>
Phillip Lougher wrote:
> This patch was prompted by Jan Blunck's "Push down BKL to the
> filesystems" patch
> series, where he firstly pushes the BKL down to individual filesystems
> (even if they don't need it) , and then successively removes them
> (on a one patch per filesystem basis) in later patches.
>
> The patch should be reviewed in the context that it is intended for Jan's
> BKL removal patch series.
>
Jan and/or Matthew,
Can you please ACK this patch, and say whether you're going to
add it to your BKL patch series? (I'm happy for it to go through
there, rather than my Squashfs tree).
After reviewing your patches, it seems to me that the BKL isn't
needed in Squashfs. You removed it from 23 filesystems because
it's not protecting any shared state, on that basis it isn't needed
needed in Squashfs either.
Thanks
Phillip
next prev parent reply other threads:[~2009-11-10 21:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-03 15:15 BKL: Remove BKL from Squashfs Phillip Lougher
2009-11-10 20:15 ` Andrew Morton
2009-11-10 21:11 ` Phillip Lougher
2009-11-10 21:37 ` Phillip Lougher [this message]
2009-11-11 15:16 ` Jan Blunck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AF9DD24.8060501@lougher.demon.co.uk \
--to=phillip@lougher.demon.co.uk \
--cc=akpm@linux-foundation.org \
--cc=jblunck@suse.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).