From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH] fs: O_* bit numbers uniqueness check
Date: Wed, 06 Jan 2010 08:07:01 +0100
Message-ID: <4B443695.5090301@gmail.com>
References: <20100106065526.GB11368@localhost>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: Andrew Morton <akpm@linux-foundation.org>,
	David Miller <davem@davemloft.net>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Al Viro <viro@zeniv.linux.org.uk>,
	Christoph Hellwig <hch@infradead.org>,
	Eric Paris <eparis@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-fsdevel@vger.kernel.org
To: Wu Fengguang <fengguang.wu@intel.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from gw1.cosmosbay.com ([212.99.114.194]:50095 "EHLO
	gw1.cosmosbay.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752166Ab0AFHRN (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Wed, 6 Jan 2010 02:17:13 -0500
In-Reply-To: <20100106065526.GB11368@localhost>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

Le 06/01/2010 07:55, Wu Fengguang a =E9crit :
> The O_* bit numbers are defined in 20+ arch/*, and hence can silently
> overlap. Add a boot time check to ensure the uniqueness as suggested
> by David Miller.
>=20
> CC: David Miller <davem@davemloft.net>
> CC: Stephen Rothwell <sfr@canb.auug.org.au>
> CC: Al Viro <viro@zeniv.linux.org.uk>
> CC: Christoph Hellwig <hch@infradead.org>
> CC: Eric Paris <eparis@redhat.com>
> Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
> ---
>  {
> +	/* please add new bits here to ensure allocation uniqueness */
> +	BUG_ON(20 !=3D hweight32(
> +		O_RDONLY	| O_WRONLY	| O_RDWR	|
> +		O_CREAT		| O_EXCL	| O_NOCTTY	|
> +		O_TRUNC		| O_APPEND	| O_NONBLOCK	|
> +		O_SYNC		| FASYNC	| O_DIRECT	|
> +		O_LARGEFILE	| O_DIRECTORY	| O_NOFOLLOW	|
> +		O_NOATIME	| O_CLOEXEC	| O_RANDOM	|
> +		FMODE_EXEC	| FMODE_NONOTIFY));
> +

I cannot test it, but given O_RDONLY is 0, are you sure 20 bits are act=
ually set ?
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel=
" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html