From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH 2/7] sysfs: Pack sysfs_dirent more tightly. Date: Tue, 12 Jan 2010 09:41:36 +0900 Message-ID: <4B4BC540.1090609@kernel.org> References: <1263241315-19499-2-git-send-email-ebiederm@xmission.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Greg Kroah-Hartman , Kay Sievers , linux-kernel@vger.kernel.org, Cornelia Huck , linux-fsdevel@vger.kernel.org, Eric Dumazet , Benjamin LaHaise , Serge Hallyn , "Eric W. Biederman" To: "Eric W. Biederman" Return-path: In-Reply-To: <1263241315-19499-2-git-send-email-ebiederm@xmission.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On 01/12/2010 05:21 AM, Eric W. Biederman wrote: > From: Eric W. Biederman > > Placing the 16bit s_mode between a pointer and a long doesn't pack well > especailly on 64bit where we wast 48 bits. So move s_mode and > declare it as a unsigned short. This is the sysfs backing store > after all we don't need fields extra large just in case someday > we want userspace to be able to use a larger value. > > Signed-off-by: Eric W. Biederman Acked-by: Tejun Heo -- tejun