linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ian Kent <raven@themaw.net>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Valerie Aurora <vaurora@redhat.com>,
	linux-fsdevel@vger.kernel.org, Jan Blunck <jblunck@suse.de>,
	autofs@linux.kernel.org, sfrench@samba.org,
	Trond.Myklebust@netapp.com, David Howells <dhowells@redhat.com>
Subject: Re: [PATCH 1/7] autofs4: Save autofs trigger's vfsmount in super block info
Date: Mon, 18 Jan 2010 12:21:09 +0800	[thread overview]
Message-ID: <4B53E1B5.2080202@themaw.net> (raw)
In-Reply-To: <20100117175723.GP19799@ZenIV.linux.org.uk>

On 01/18/2010 01:57 AM, Al Viro wrote:
> On Sat, Jan 16, 2010 at 10:17:14AM +0000, Al Viro wrote:
>> 	* [unsolved, to be dealt along with per-superblock write counts]
>> do_remount() plays fast and loose with MNT_READONLY for !MS_BIND case.
>> 	* [*really* unsolved] it remains to be seen whether we want to
>> propagate modifications of mount flags via shared subtree stuff.  For most
>> of those it's trivial (and arguably the right thing to do), but ro/rw is
>> really nasty.  Nick's mnt_want_write() implementation will need very careful
>> analysis.
> 
> 	Speaking of autofs4, what the hell is going on in
> autofs_dev_ioctl_ismountpoint()?  Checks in there make no sense,
> both the "could that dentry be negative?" and whatever the hell
> it is trying to do with mnt_mountpoint.  Ian?

In that case we may find an autofs mount that has something mounted on
top of it and user space wants to know the super of the covering mount.

If there is something mounted on top of it user space needs to know if
it is another autofs file system or some other type of file system. So
if the nameidata path, located by autofs_dev_ioctl_find_super(), is not
the top (or bottom, depending on the terminology you prefer) then we
need to follow the mount and return the magic of the thing mounted on
top of it.

Ian

  reply	other threads:[~2010-01-18  4:21 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-23 23:36 [PATCH 0/7] VFS prep for union mounts/writable overlays Valerie Aurora
2009-12-23 23:36 ` [PATCH 1/7] autofs4: Save autofs trigger's vfsmount in super block info Valerie Aurora
2009-12-23 23:36   ` [PATCH 2/7] VFS: Make lookup_hash() return a struct path Valerie Aurora
2009-12-23 23:36     ` [PATCH 3/7] VFS: Make real_lookup() " Valerie Aurora
2009-12-23 23:37       ` [PATCH 4/7] VFS: Propagate mnt_flags into do_loopback Valerie Aurora
2009-12-23 23:37         ` [PATCH 5/7] VFS: Add read-only users count to superblock Valerie Aurora
2009-12-23 23:37           ` [PATCH 6/7] VFS: BUG_ON() rehash of an already hashed dentry Valerie Aurora
2009-12-23 23:37             ` [PATCH 7/7] VFS: Remove unnecessary micro-optimization in cached_lookup() Valerie Aurora
2010-01-02  0:44   ` [PATCH 1/7] autofs4: Save autofs trigger's vfsmount in super block info Ian Kent
2010-01-14  5:43     ` Al Viro
2010-01-14 19:18       ` Valerie Aurora
2010-01-15  6:05         ` Ian Kent
2010-01-15  8:03           ` Al Viro
2010-01-15 17:36             ` Steve French
2010-01-18  5:08             ` Ian Kent
2010-01-15 14:55           ` David Howells
2010-01-15 16:58             ` Al Viro
2010-01-15 17:08             ` David Howells
2010-01-15 17:26               ` Al Viro
2010-01-16 10:17                 ` Al Viro
2010-01-17 17:57                   ` Al Viro
2010-01-18  4:21                     ` Ian Kent [this message]
2010-01-18  5:59                       ` Al Viro
2010-01-18  9:14                         ` Ian Kent
2010-01-18 10:27                           ` Al Viro
2010-01-18 19:35                             ` Trond Myklebust
2010-01-19  7:05                             ` Ian Kent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B53E1B5.2080202@themaw.net \
    --to=raven@themaw.net \
    --cc=Trond.Myklebust@netapp.com \
    --cc=autofs@linux.kernel.org \
    --cc=dhowells@redhat.com \
    --cc=jblunck@suse.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=sfrench@samba.org \
    --cc=vaurora@redhat.com \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).