linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ian Kent <raven@themaw.net>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Valerie Aurora <vaurora@redhat.com>,
	linux-fsdevel@vger.kernel.org, Jan Blunck <jblunck@suse.de>,
	autofs@linux.kernel.org, sfrench@samba.org, dhowells@redhat.com,
	Trond.Myklebust@netapp.com
Subject: Re: [PATCH 1/7] autofs4: Save autofs trigger's vfsmount in super block info
Date: Mon, 18 Jan 2010 13:08:12 +0800	[thread overview]
Message-ID: <4B53ECBC.8030309@themaw.net> (raw)
In-Reply-To: <20100115080323.GK19799@ZenIV.linux.org.uk>

On 01/15/2010 04:03 PM, Al Viro wrote:
> 	* what's going on with use of intent flags in case of autofs4?

It's the same old story.
autofs needs to take care not to trigger mounts for certain system calls
when we have reached the last path component. AFAIK the only way to do
that is to check the flags.

> 
> Other than that, it'd seem that we would be better off if we treated these
> guys as "if we try to follow mountpoint and that sucker turns out to be
> the end of the road, do something fs-specific and either try to go further
> or see if we could attach the mountpoint given to us here".  Which might
> be better done in VFS, with fs method returning vfsmount, NULL or ERR_PTR.

Forgive my thickness but am I understanding this correctly?

Are you just saying it would be better to add a file system method to
cater for the case where we might need to do further resolution on the
mount root we have just arrived at before continuing into it (mmm ...
now it feels like I've stated the obvious, but anyway ...)?

Would that be before following the link or after (not that it would
matter for my needs)?

Ian

  parent reply	other threads:[~2010-01-18  5:08 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-23 23:36 [PATCH 0/7] VFS prep for union mounts/writable overlays Valerie Aurora
2009-12-23 23:36 ` [PATCH 1/7] autofs4: Save autofs trigger's vfsmount in super block info Valerie Aurora
2009-12-23 23:36   ` [PATCH 2/7] VFS: Make lookup_hash() return a struct path Valerie Aurora
2009-12-23 23:36     ` [PATCH 3/7] VFS: Make real_lookup() " Valerie Aurora
2009-12-23 23:37       ` [PATCH 4/7] VFS: Propagate mnt_flags into do_loopback Valerie Aurora
2009-12-23 23:37         ` [PATCH 5/7] VFS: Add read-only users count to superblock Valerie Aurora
2009-12-23 23:37           ` [PATCH 6/7] VFS: BUG_ON() rehash of an already hashed dentry Valerie Aurora
2009-12-23 23:37             ` [PATCH 7/7] VFS: Remove unnecessary micro-optimization in cached_lookup() Valerie Aurora
2010-01-02  0:44   ` [PATCH 1/7] autofs4: Save autofs trigger's vfsmount in super block info Ian Kent
2010-01-14  5:43     ` Al Viro
2010-01-14 19:18       ` Valerie Aurora
2010-01-15  6:05         ` Ian Kent
2010-01-15  8:03           ` Al Viro
2010-01-15 17:36             ` Steve French
2010-01-18  5:08             ` Ian Kent [this message]
2010-01-15 14:55           ` David Howells
2010-01-15 16:58             ` Al Viro
2010-01-15 17:08             ` David Howells
2010-01-15 17:26               ` Al Viro
2010-01-16 10:17                 ` Al Viro
2010-01-17 17:57                   ` Al Viro
2010-01-18  4:21                     ` Ian Kent
2010-01-18  5:59                       ` Al Viro
2010-01-18  9:14                         ` Ian Kent
2010-01-18 10:27                           ` Al Viro
2010-01-18 19:35                             ` Trond Myklebust
2010-01-19  7:05                             ` Ian Kent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B53ECBC.8030309@themaw.net \
    --to=raven@themaw.net \
    --cc=Trond.Myklebust@netapp.com \
    --cc=autofs@linux.kernel.org \
    --cc=dhowells@redhat.com \
    --cc=jblunck@suse.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=sfrench@samba.org \
    --cc=vaurora@redhat.com \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).