* [PATCH] fs: buffer_head, remove kmem_cache constructor to reduce memory usage under slub
@ 2010-02-09 13:29 Richard Kennedy
2010-02-09 14:31 ` Nick Piggin
2010-02-09 16:48 ` Rik van Riel
0 siblings, 2 replies; 3+ messages in thread
From: Richard Kennedy @ 2010-02-09 13:29 UTC (permalink / raw)
To: Alexander Viro, Andrew Morton
Cc: linux-fsdevel, lkml, Jens Axboe, Nick Piggin, Theodore Ts'o
fs: Remove the buffer_head kmem_cache constructor to reduce memory usage
under slub.
When using slub, having a kmem_cache constructor forces slub to add a
free pointer to the size of the cached object, which can have a
significant impact to the number of small objects that can fit into a
slab.
As buffer_head is relatively small and we can have large numbers of
them, removing the constructor is a definite win.
On x86_64 removing the constructor gives me 39 objects/slab, 3 more than
without the patch. And on x86_32 73 objects/slab, which is 9 more.
As alloc_buffer_head() already initializes each new object there is very
little difference in actual code run.
Signed-off-by: Richard Kennedy <richard@rsk.demon.co.uk>
----
This patch against 2.6.33-rc7
I've been running this patch for over a week on both a x86_64 desktop &
a x86_32 laptop with no problems, only having fewer pages in the
buffer_head cache :)
regards
Richard
diff --git a/fs/buffer.c b/fs/buffer.c
index 6fa5302..bc3212e 100644
--- a/fs/buffer.c
+++ b/fs/buffer.c
@@ -3265,7 +3265,7 @@ static void recalc_bh_state(void)
struct buffer_head *alloc_buffer_head(gfp_t gfp_flags)
{
- struct buffer_head *ret = kmem_cache_alloc(bh_cachep, gfp_flags);
+ struct buffer_head *ret = kmem_cache_zalloc(bh_cachep, gfp_flags);
if (ret) {
INIT_LIST_HEAD(&ret->b_assoc_buffers);
get_cpu_var(bh_accounting).nr++;
@@ -3352,15 +3352,6 @@ int bh_submit_read(struct buffer_head *bh)
}
EXPORT_SYMBOL(bh_submit_read);
-static void
-init_buffer_head(void *data)
-{
- struct buffer_head *bh = data;
-
- memset(bh, 0, sizeof(*bh));
- INIT_LIST_HEAD(&bh->b_assoc_buffers);
-}
-
void __init buffer_init(void)
{
int nrpages;
@@ -3369,7 +3360,7 @@ void __init buffer_init(void)
sizeof(struct buffer_head), 0,
(SLAB_RECLAIM_ACCOUNT|SLAB_PANIC|
SLAB_MEM_SPREAD),
- init_buffer_head);
+ NULL);
/*
* Limit the bh occupancy to 10% of ZONE_NORMAL
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] fs: buffer_head, remove kmem_cache constructor to reduce memory usage under slub
2010-02-09 13:29 [PATCH] fs: buffer_head, remove kmem_cache constructor to reduce memory usage under slub Richard Kennedy
@ 2010-02-09 14:31 ` Nick Piggin
2010-02-09 16:48 ` Rik van Riel
1 sibling, 0 replies; 3+ messages in thread
From: Nick Piggin @ 2010-02-09 14:31 UTC (permalink / raw)
To: Richard Kennedy
Cc: Alexander Viro, Andrew Morton, linux-fsdevel, lkml, Jens Axboe,
Theodore Ts'o
On Tue, Feb 09, 2010 at 01:29:51PM +0000, Richard Kennedy wrote:
> fs: Remove the buffer_head kmem_cache constructor to reduce memory usage
> under slub.
>
> When using slub, having a kmem_cache constructor forces slub to add a
> free pointer to the size of the cached object, which can have a
> significant impact to the number of small objects that can fit into a
> slab.
>
> As buffer_head is relatively small and we can have large numbers of
> them, removing the constructor is a definite win.
>
> On x86_64 removing the constructor gives me 39 objects/slab, 3 more than
> without the patch. And on x86_32 73 objects/slab, which is 9 more.
>
> As alloc_buffer_head() already initializes each new object there is very
> little difference in actual code run.
>
> Signed-off-by: Richard Kennedy <richard@rsk.demon.co.uk>
Looks fine to me. Seems like it should reduce temporal cache footprint
too by just touching the objects as they are used.
Acked-by: Nick Piggin <npiggin@suse.de>
> ----
> This patch against 2.6.33-rc7
>
> I've been running this patch for over a week on both a x86_64 desktop &
> a x86_32 laptop with no problems, only having fewer pages in the
> buffer_head cache :)
>
> regards
> Richard
>
>
>
>
> diff --git a/fs/buffer.c b/fs/buffer.c
> index 6fa5302..bc3212e 100644
> --- a/fs/buffer.c
> +++ b/fs/buffer.c
> @@ -3265,7 +3265,7 @@ static void recalc_bh_state(void)
>
> struct buffer_head *alloc_buffer_head(gfp_t gfp_flags)
> {
> - struct buffer_head *ret = kmem_cache_alloc(bh_cachep, gfp_flags);
> + struct buffer_head *ret = kmem_cache_zalloc(bh_cachep, gfp_flags);
> if (ret) {
> INIT_LIST_HEAD(&ret->b_assoc_buffers);
> get_cpu_var(bh_accounting).nr++;
> @@ -3352,15 +3352,6 @@ int bh_submit_read(struct buffer_head *bh)
> }
> EXPORT_SYMBOL(bh_submit_read);
>
> -static void
> -init_buffer_head(void *data)
> -{
> - struct buffer_head *bh = data;
> -
> - memset(bh, 0, sizeof(*bh));
> - INIT_LIST_HEAD(&bh->b_assoc_buffers);
> -}
> -
> void __init buffer_init(void)
> {
> int nrpages;
> @@ -3369,7 +3360,7 @@ void __init buffer_init(void)
> sizeof(struct buffer_head), 0,
> (SLAB_RECLAIM_ACCOUNT|SLAB_PANIC|
> SLAB_MEM_SPREAD),
> - init_buffer_head);
> + NULL);
>
> /*
> * Limit the bh occupancy to 10% of ZONE_NORMAL
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fs: buffer_head, remove kmem_cache constructor to reduce memory usage under slub
2010-02-09 13:29 [PATCH] fs: buffer_head, remove kmem_cache constructor to reduce memory usage under slub Richard Kennedy
2010-02-09 14:31 ` Nick Piggin
@ 2010-02-09 16:48 ` Rik van Riel
1 sibling, 0 replies; 3+ messages in thread
From: Rik van Riel @ 2010-02-09 16:48 UTC (permalink / raw)
To: Richard Kennedy
Cc: Alexander Viro, Andrew Morton, linux-fsdevel, lkml, Jens Axboe,
Nick Piggin, Theodore Ts'o
On 02/09/2010 08:29 AM, Richard Kennedy wrote:
> fs: Remove the buffer_head kmem_cache constructor to reduce memory usage
> under slub.
>
> When using slub, having a kmem_cache constructor forces slub to add a
> free pointer to the size of the cached object, which can have a
> significant impact to the number of small objects that can fit into a
> slab.
>
> As buffer_head is relatively small and we can have large numbers of
> them, removing the constructor is a definite win.
>
> On x86_64 removing the constructor gives me 39 objects/slab, 3 more than
> without the patch. And on x86_32 73 objects/slab, which is 9 more.
>
> As alloc_buffer_head() already initializes each new object there is very
> little difference in actual code run.
>
> Signed-off-by: Richard Kennedy<richard@rsk.demon.co.uk>
Reviewed-by: Rik van Riel <riel@redhat.com>
--
All rights reversed.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-02-09 16:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-09 13:29 [PATCH] fs: buffer_head, remove kmem_cache constructor to reduce memory usage under slub Richard Kennedy
2010-02-09 14:31 ` Nick Piggin
2010-02-09 16:48 ` Rik van Riel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).