From mboxrd@z Thu Jan  1 00:00:00 1970
From: Boaz Harrosh <bharrosh@panasas.com>
Subject: Re: [PATCH 05/19] exofs: replace inode uid,gid,mode initialization
 with helper function
Date: Fri, 19 Feb 2010 16:15:50 -0800
Message-ID: <4B7F29B6.9000200@panasas.com>
References: <1266431353-8549-1-git-send-email-dmonakhov@openvz.org> <1266431955-9137-1-git-send-email-dmonakhov@openvz.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: linux-fsdevel@vger.kernel.org, osd-dev@open-osd.org
To: Dmitry Monakhov <dmonakhov@openvz.org>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from daytona.panasas.com ([67.152.220.89]:36992 "EHLO
	daytona.int.panasas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
	with ESMTP id S1751353Ab0BTAPu (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Fri, 19 Feb 2010 19:15:50 -0500
In-Reply-To: <1266431955-9137-1-git-send-email-dmonakhov@openvz.org>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On 02/17/2010 10:39 AM, Dmitry Monakhov wrote:
> Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>

Ack-by: Boaz Harrosh <bharrosh@panasas.com>

> ---
>  fs/exofs/inode.c |   11 +----------
>  1 files changed, 1 insertions(+), 10 deletions(-)
> 
> diff --git a/fs/exofs/inode.c b/fs/exofs/inode.c
> index 2afbceb..466ad0d 100644
> --- a/fs/exofs/inode.c
> +++ b/fs/exofs/inode.c
> @@ -1083,16 +1083,7 @@ struct inode *exofs_new_inode(struct inode *dir, int mode)
>  	sbi = sb->s_fs_info;
>  
>  	sb->s_dirt = 1;
> -	inode->i_uid = current->cred->fsuid;
> -	if (dir->i_mode & S_ISGID) {
> -		inode->i_gid = dir->i_gid;
> -		if (S_ISDIR(mode))
> -			mode |= S_ISGID;
> -	} else {
> -		inode->i_gid = current->cred->fsgid;
> -	}
> -	inode->i_mode = mode;
> -
> +	inode_init_owner(inode, dir, mode);
>  	inode->i_ino = sbi->s_nextid++;
>  	inode->i_blkbits = EXOFS_BLKSHIFT;
>  	inode->i_mtime = inode->i_atime = inode->i_ctime = CURRENT_TIME;