From mboxrd@z Thu Jan  1 00:00:00 1970
From: Boaz Harrosh <bharrosh@panasas.com>
Subject: Re: [rfc][patch] mm, fs: warn on missing address space operations
Date: Mon, 22 Mar 2010 14:05:52 +0200
Message-ID: <4BA75D20.2060905@panasas.com>
References: <20100322053937.GA17637@laptop> <4BA7359B.2060603@panasas.com> <20100322105442.GH17637@laptop>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
To: Nick Piggin <npiggin@suse.de>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <20100322105442.GH17637@laptop>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On 03/22/2010 12:54 PM, Nick Piggin wrote:
> On Mon, Mar 22, 2010 at 11:17:15AM +0200, Boaz Harrosh wrote:
>> ---
>> git diff --stat -p -M fs/exofs/inode.c
>>  fs/exofs/inode.c |    8 ++++++++
>>  1 files changed, 8 insertions(+), 0 deletions(-)
>>
>> diff --git a/fs/exofs/inode.c b/fs/exofs/inode.c
>> index a17e4b7..85dd847 100644
>> --- a/fs/exofs/inode.c
>> +++ b/fs/exofs/inode.c
>> @@ -754,6 +754,11 @@ static int exofs_write_end(struct file *file, struct address_space *mapping,
>>  	return ret;
>>  }
>>  
>> +static int exofs_releasepage(struct page *page, gfp_t gfp)
>> +{
>> +	return try_to_free_buffers(page);
>> +}
>> +
>>  const struct address_space_operations exofs_aops = {
>>  	.readpage	= exofs_readpage,
>>  	.readpages	= exofs_readpages,
>> @@ -761,6 +766,9 @@ const struct address_space_operations exofs_aops = {
>>  	.writepages	= exofs_writepages,
>>  	.write_begin	= exofs_write_begin_export,
>>  	.write_end	= exofs_write_end,
>> +	.releasepage	= exofs_releasepage,
>> +	.set_page_dirty	= __set_page_dirty_buffers,
>> +	.invalidatepage = block_invalidatepage,
>>  };
> 
> AFAIKS, you aren't using buffer heads at all (except nobh_truncate,
> which will not attach buffers to pages)?
> 
> If so, you should only need __set_page_dirty_nobuffers.
> 

Ho, thanks, that one is much better, yes.

BTW:
The use of nobh_truncate, I hope will go away after your:
	fs: truncate introduce new sequence
with these two helpers you added I can actually get rid of
that as well. (I think. I keep postponing this work ;-))

> Thanks,
> Nick
> 

Thanks
Boaz