From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benny Halevy Subject: Re: [pnfs] [GIT BISECT] first bad commit: 1f36f774 Switch !O_CREAT case to use of do_last() Date: Thu, 25 Mar 2010 13:19:32 +0200 Message-ID: <4BAB46C4.1050604@panasas.com> References: <20100324163948.GR30031@ZenIV.linux.org.uk> <4BAA48A3.1030801@panasas.com> <4BAA4CAC.6060104@panasas.com> <4BAA5035.1060906@panasas.com> <4BAA52A8.2080304@panasas.com> <20100324180622.GS30031@ZenIV.linux.org.uk> <4BAA5955.4000001@gmail.com> <20100324185604.GT30031@ZenIV.linux.org.uk> <4BAB2F5A.30409@panasas.com> <20100325101231.GU30031@ZenIV.linux.org.uk> <20100325105406.GW30031@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Boaz Harrosh , linux-fsdevel , "J. Bruce Fields" , pNFS Mailing List , linux-kernel , Doug Nazar To: Al Viro Return-path: In-Reply-To: <20100325105406.GW30031@ZenIV.linux.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Mar. 25, 2010, 12:54 +0200, Al Viro wrote: > On Thu, Mar 25, 2010 at 10:12:31AM +0000, Al Viro wrote: >> On Thu, Mar 25, 2010 at 11:39:38AM +0200, Boaz Harrosh wrote: >> >>> It makes no difference, fails just the same. Would an "strace" help? >> It might, especially if you ran it for identical repositories on local >> fs and on NFS; at least that way it would be possible to see where do >> they diverge... > > I wonder... What happens if you add > if (error == -EISDIR) > printk("blah: %s", pathname); I'll add that check too. Benny > right after do_lookup() call in do_last()? That would separate -EISDIR > coming from NFS from the same thing coming from fs/namei.c... > _______________________________________________ > pNFS mailing list > pNFS@linux-nfs.org > http://linux-nfs.org/cgi-bin/mailman/listinfo/pnfs