From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benny Halevy Subject: Re: [pnfs] [GIT BISECT] first bad commit: 1f36f774 Switch !O_CREAT case to use of do_last() Date: Thu, 25 Mar 2010 16:36:41 +0200 Message-ID: <4BAB74F9.7040106@panasas.com> References: <20100324185604.GT30031@ZenIV.linux.org.uk> <4BAB2F5A.30409@panasas.com> <20100325101231.GU30031@ZenIV.linux.org.uk> <20100325105406.GW30031@ZenIV.linux.org.uk> <4BAB51F5.609@panasas.com> <4BAB54B0.3080109@panasas.com> <20100325130610.GZ30031@ZenIV.linux.org.uk> <4BAB656E.8020204@panasas.com> <20100325133746.GA30031@ZenIV.linux.org.uk> <4BAB6A99.5070209@panasas.com> <20100325140605.GC30031@ZenIV.linux.org.uk> <4BAB6E36.6040106@panasas.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: pNFS Mailing List , "J. Bruce Fields" , Trond Myklebust , linux-kernel , Doug Nazar , linux-fsdevel To: Al Viro Return-path: In-Reply-To: <4BAB6E36.6040106@panasas.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Mar. 25, 2010, 16:07 +0200, Benny Halevy wrote: > On Mar. 25, 2010, 16:06 +0200, Al Viro wrote: >> On Thu, Mar 25, 2010 at 03:52:25PM +0200, Benny Halevy wrote: >>> On Mar. 25, 2010, 15:37 +0200, Al Viro wrote: >>>> On Thu, Mar 25, 2010 at 03:30:22PM +0200, Boaz Harrosh wrote: >>>>>> Let's try this: before do_lookup() call there add >>>>>> if (*want_dir) >>>>>> nd->flags |= LOOKUP_DIRECTORY; >>>>> Yes this fixes it!! >>>>> 2.6.34-rc2 plus above, now works, horay. (diff attached) >>>>> >>>>>> and see how does it behave. >>>>>> >>>>>> However, even if it does help, it doesn't explain everything. Normal >>>>>> open() on a directory without O_DIRECTORY if flags shouldn't fail with >>>>>> -EISDIR. How did that manage to avoid it all along? >>>> Does open() of directory _without_ O_DIRECTORY work in e.g. vanilla 2.6.33? >>>> It certainly does for local filesystems and it does for NFSv3; does it work >>>> for NFSv4? >>> No, it doesn't. >>> >>> # mount localhost:/usr0/nfs4export /mnt/localhost; strace cat /mnt/localhost/server 2>&1 | grep 'open.*server'; umount /mnt/localhost >>> open("/mnt/localhost/server", O_RDONLY) = 3 >>> >>> # mount -t nfs4 localhost:/ /mnt/localhost; strace cat /mnt/localhost/server 2>&1 | grep 'open.*server'; umount /mnt/localhost >>> open("/mnt/localhost/server", O_RDONLY) = -1 EISDIR (Is a directory) >> Gets better - if you do ls -l /mnt/localhost/server and then repeat that >> open(), it'll succeed. > > Correct :) So, previously (pre 1f36f77), do_last called do_path_lookup with lookup_flags(open_flag)|LOOKUP_OPEN and lookup_flags did - if (f & O_DIRECTORY) - retval |= LOOKUP_DIRECTORY; and this was dropped in 1f36f77, right? Benny > _______________________________________________ > pNFS mailing list > pNFS@linux-nfs.org > http://linux-nfs.org/cgi-bin/mailman/listinfo/pnfs