From: Jiri Slaby <jslaby@suse.cz>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Avi Kivity <avi@redhat.com>, Changli Gao <xiaosuo@gmail.com>,
Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
akpm@linux-foundation.org, paulmck@linux.vnet.ibm.com,
adobriyan@gmail.com, mingo@elte.hu, peterz@infradead.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs: use kmalloc() to allocate fdmem if possible
Date: Mon, 03 May 2010 11:19:00 +0200 [thread overview]
Message-ID: <4BDE9504.8030401@suse.cz> (raw)
In-Reply-To: <1272878032.2226.27.camel@edumazet-laptop>
On 05/03/2010 11:13 AM, Eric Dumazet wrote:
> /*
> * Warning: if size is not a power of two, kmalloc() might
> * waste memory because of its requirements.
> */
> void *kvmalloc(size_t size)
> {
> void *ptr = kmalloc(size, GFP_KERNEL | __GFP_NOWARN);
This is kind of waste of high-order pages, isn't it? Wouldn't it be
better to have a watermark where we skip kmalloc completely?
>
> if (ptr)
> return ptr;
> return vmalloc(size);
> }
--
js
suse labs
next prev parent reply other threads:[~2010-05-03 9:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Alexander Viro <viro@zeniv.linux.org.uk>
2010-05-02 16:46 ` [PATCH] fs: use kmalloc() to allocate fdmem if possible Changli Gao
2010-05-02 17:31 ` Avi Kivity
2010-05-03 0:15 ` Tetsuo Handa
2010-05-03 6:06 ` Avi Kivity
2010-05-03 7:05 ` Changli Gao
2010-05-03 7:42 ` Avi Kivity
2010-05-03 7:52 ` Changli Gao
2010-05-03 8:49 ` Avi Kivity
2010-05-03 9:03 ` Jiri Slaby
2010-05-03 9:18 ` Avi Kivity
2010-05-03 9:22 ` Jiri Slaby
2010-05-03 9:25 ` Jiri Slaby
2010-05-03 9:28 ` Avi Kivity
2010-05-03 9:13 ` Eric Dumazet
2010-05-03 9:19 ` Jiri Slaby [this message]
2010-05-03 9:29 ` Eric Dumazet
2010-05-04 4:20 ` Changli Gao
2010-05-04 5:33 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BDE9504.8030401@suse.cz \
--to=jslaby@suse.cz \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=avi@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulmck@linux.vnet.ibm.com \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=peterz@infradead.org \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).