From: Tejun Heo <tj@kernel.org>
To: Nick Piggin <npiggin@suse.de>
Cc: linux-fsdevel@vger.kernel.org, Jens Axboe <jens.axboe@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [patch] block: bd_start_claiming fix module refcount
Date: Tue, 25 May 2010 19:03:21 +0200 [thread overview]
Message-ID: <4BFC02D9.2090408@kernel.org> (raw)
In-Reply-To: <20100525155021.GC20853@laptop>
Hello,
On 05/25/2010 05:50 PM, Nick Piggin wrote:
>
> bd_start_claiming has an unbalanced module_put introduced in 6b4517a79.
>
> Signed-off-by: Nick Piggin <npiggin@suse.de>
Acked-by: Tejun Heo <tj@kernel.org>
I think it might be a good idea to rename get_disk().
get_disk/put_disk() pair is somewhat deceptive.
Thanks.
--
tejun
prev parent reply other threads:[~2010-05-25 17:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-25 15:50 [patch] block: bd_start_claiming fix module refcount Nick Piggin
2010-05-25 15:51 ` [patch] block: bd_start_claiming cleanup Nick Piggin
2010-05-25 17:30 ` Tejun Heo
2010-05-25 17:03 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BFC02D9.2090408@kernel.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=jens.axboe@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=npiggin@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).