From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tejun Heo <tj@kernel.org>
Subject: Re: [patch] block: bd_start_claiming fix module refcount
Date: Tue, 25 May 2010 19:03:21 +0200
Message-ID: <4BFC02D9.2090408@kernel.org>
References: <20100525155021.GC20853@laptop>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: linux-fsdevel@vger.kernel.org, Jens Axboe <jens.axboe@oracle.com>,
	Andrew Morton <akpm@linux-foundation.org>
To: Nick Piggin <npiggin@suse.de>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from hera.kernel.org ([140.211.167.34]:42355 "EHLO hera.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932719Ab0EYREA (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Tue, 25 May 2010 13:04:00 -0400
In-Reply-To: <20100525155021.GC20853@laptop>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

Hello,

On 05/25/2010 05:50 PM, Nick Piggin wrote:
> 
> bd_start_claiming has an unbalanced module_put introduced in 6b4517a79.
> 
> Signed-off-by: Nick Piggin <npiggin@suse.de>

Acked-by: Tejun Heo <tj@kernel.org>

I think it might be a good idea to rename get_disk().
get_disk/put_disk() pair is somewhat deceptive.

Thanks.

-- 
tejun