Re: [RFC] exofs: New truncate sequence

[Boaz Harrosh <bharrosh@panasas.com>]

On 05/31/2010 06:09 PM, Nick Piggin wrote:
> On Mon, May 31, 2010 at 05:50:01PM +0300, Boaz Harrosh wrote:
>> On 05/31/2010 05:33 PM, Nick Piggin wrote:
>>> On Mon, May 31, 2010 at 05:13:34PM +0300, Boaz Harrosh wrote:
>>>> On 05/31/2010 04:44 PM, Nick Piggin wrote:
>>>>> On Mon, May 31, 2010 at 03:30:02PM +0300, Boaz Harrosh wrote:
>>>>>> ---
>>>>>>  fs/exofs/exofs.h |    1 -
>>>>>>  fs/exofs/file.c  |    1 -
>>>>>>  fs/exofs/inode.c |  115 +++++++++++++++++++++++++++---------------------------
>>>>>
>>>>> Can you rip out all the rest of the buffer_head stuff too?
>>>>>
>>>>
>>>> I hope I don't have any left, that was the last, have I missed
>>>> something?
>>>
>>> exofs_invalidatepage, exofs_releasepage, includes of buffer_head.h.
>>> No point to any of that if you never actually map the buffers or
>>> use them for tracking state yourself.
>>>
>>
>> Rrr thanks. Yes I'll leave the WARN_ON and do nothing, and remove the
>> include. I'll submit for linux-next.
> 
> OK. I'd get rid of it completely before it hits mainline.
> 
> 

No this one I've already queued for Linux next. On me ;-)

> 
> I would keep them based on top of Christoph's patches (just cherry
> pick the exofs hunks in the meantime).
> 

You mean pick them from the mailing-list. But then there is no chance
for them to go into linux-next and pick up some testing. That's why
I thought on rebasing on Linus-2.6.35-rc1.

Then when Christoph's patches get picked by Al I'll rebase. But the
base is just good right now and I'd like some exposure for this.

Christoph this is your call

Boaz