From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boaz Harrosh Subject: Re: [patch v2] fix truncate inode time modification breakage Date: Thu, 03 Jun 2010 15:13:43 +0300 Message-ID: <4C079C77.70801@panasas.com> References: <20100601133923.GT9453@laptop> <20100601134801.GA11061@lst.de> <20100601135655.GU9453@laptop> <20100602195538.GG6152@laptop> <4C076A7B.5040802@panasas.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: npiggin@suse.de, hch@lst.de, viro@ZenIV.linux.org.uk, linux-fsdevel@vger.kernel.org To: Miklos Szeredi Return-path: Received: from daytona.panasas.com ([67.152.220.89]:47386 "EHLO daytona.int.panasas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751232Ab0FCMNq (ORCPT ); Thu, 3 Jun 2010 08:13:46 -0400 In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 06/03/2010 12:05 PM, Miklos Szeredi wrote: > On Thu, 03 Jun 2010, Boaz Harrosh wrote: >>> Fuse philosophy is: each operation itself has to update times on files >>> if necessary. So it basically moves the responsibility to update >>> [amc]time from the VFS into the filesystem. >>> >>> This means the only place fuse is interested in ATTR_ATIME or >>> ATTR_MTIME is for the utime* syscalls. >>> >>> It also means that fuse always ignores ATTR_CTIME which is never set >>> explicitly. >>> >>> So I believe the current fuse code is correct. >>> >> >> It might be correct, but there were reports it has problems with NFS export. > > Do you have details? I can't remember any report related to time > modification and NFS export. > >> Why let the filesystems be broken? Why not do the common stuff >> common? (In VFS) > > For consistency and simplicity. The fuse API looks much like the > syscall API, which means that for a truncate() call on a fuse file the > truncate() method will be called in the filesystem, not a truncate() + > utimes(). And so on... > OK So that has now changed there is a ->setattr from VFS ->truncate is been killed. And the VFS could be trusted to do what it knows how to do? (I think) > Thanks, > Miklos Boaz