From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: [PATCH 2/6] writeback: queue work on stack in writeback_inodes_sb Date: Tue, 08 Jun 2010 21:51:03 +0200 Message-ID: <4C0E9F27.4050806@kernel.dk> References: <20100608161424.GA11735@lst.de> <20100608161443.GC11735@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org To: Christoph Hellwig Return-path: Received: from 0122700014.0.fullrate.dk ([95.166.99.235]:35177 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751961Ab0FHTvE (ORCPT ); Tue, 8 Jun 2010 15:51:04 -0400 In-Reply-To: <20100608161443.GC11735@lst.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 08/06/10 18.14, Christoph Hellwig wrote: > If we want to rely on s_umount in the caller we need to wait for completion > of the I/O submission before returning to the caller. Refactor > bdi_sync_writeback into a bdi_queue_work_onstack helper and use it for this > case. Looks good to me. -- Jens Axboe