From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: [PATCH 6/6] writeback: simplify and split bdi_start_writeback Date: Tue, 08 Jun 2010 21:52:32 +0200 Message-ID: <4C0E9F80.5060706@kernel.dk> References: <20100608161424.GA11735@lst.de> <20100608161515.GG11735@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org To: Christoph Hellwig Return-path: Received: from 0122700014.0.fullrate.dk ([95.166.99.235]:35189 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755580Ab0FHTwc (ORCPT ); Tue, 8 Jun 2010 15:52:32 -0400 In-Reply-To: <20100608161515.GG11735@lst.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 08/06/10 18.15, Christoph Hellwig wrote: > bdi_start_writeback now never gets a superblock passed, so we can just remove > that case. And to further untangle the code and flatten the call stack > split it into two trivial helpers for it's two callers. This also looks fine. Overall it's a nice patch series, makes the code a lot more readable as well. -- Jens Axboe